From 3f78b386b6a67934cf1c2d0ecfb1763f6f4f7d78 Mon Sep 17 00:00:00 2001 From: Clint Wylie Date: Thu, 31 Jan 2019 17:24:18 -0800 Subject: [PATCH 1/3] use System.err and System.out to print exit messages on CliPeon --- services/src/main/java/org/apache/druid/cli/CliPeon.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/services/src/main/java/org/apache/druid/cli/CliPeon.java b/services/src/main/java/org/apache/druid/cli/CliPeon.java index 991429bc57b0..2b83e3b5d3c0 100644 --- a/services/src/main/java/org/apache/druid/cli/CliPeon.java +++ b/services/src/main/java/org/apache/druid/cli/CliPeon.java @@ -35,6 +35,7 @@ import io.airlift.airline.Arguments; import io.airlift.airline.Command; import io.airlift.airline.Option; +import io.netty.util.SuppressForbidden; import org.apache.druid.client.cache.CacheConfig; import org.apache.druid.client.coordinator.CoordinatorClient; import org.apache.druid.client.indexing.HttpIndexingServiceClient; @@ -345,6 +346,7 @@ public SegmentListerResource getSegmentListerResource( ); } + @SuppressForbidden(reason = "System#out, System#err") @Override public void run() { @@ -375,14 +377,14 @@ public void run() Runtime.getRuntime().removeShutdownHook(hook); } catch (IllegalStateException e) { - log.warn("Cannot remove shutdown hook, already shutting down"); + System.err.println("Cannot remove shutdown hook, already shutting down!"); } } catch (Throwable t) { - log.error(t, "Error when starting up. Failing."); + System.err.println(Throwables.getStackTraceAsString(t)); System.exit(1); } - log.info("Finished peon task"); + System.out.println("Finished peon task"); } catch (Exception e) { throw Throwables.propagate(e); From c37ac1bce02c0174ece4067e20b44d2ac20032b2 Mon Sep 17 00:00:00 2001 From: Clint Wylie Date: Thu, 31 Jan 2019 17:26:53 -0800 Subject: [PATCH 2/3] more --- services/src/main/java/org/apache/druid/cli/CliPeon.java | 1 + 1 file changed, 1 insertion(+) diff --git a/services/src/main/java/org/apache/druid/cli/CliPeon.java b/services/src/main/java/org/apache/druid/cli/CliPeon.java index 2b83e3b5d3c0..fbbac3d30c2c 100644 --- a/services/src/main/java/org/apache/druid/cli/CliPeon.java +++ b/services/src/main/java/org/apache/druid/cli/CliPeon.java @@ -381,6 +381,7 @@ public void run() } } catch (Throwable t) { + System.err.println("ERROR stopping!"); System.err.println(Throwables.getStackTraceAsString(t)); System.exit(1); } From c17dede449cd9a273d00eb2659acc2fb45ce3c62 Mon Sep 17 00:00:00 2001 From: Clint Wylie Date: Thu, 31 Jan 2019 17:35:46 -0800 Subject: [PATCH 3/3] not necessarily a stopping error... --- services/src/main/java/org/apache/druid/cli/CliPeon.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/src/main/java/org/apache/druid/cli/CliPeon.java b/services/src/main/java/org/apache/druid/cli/CliPeon.java index fbbac3d30c2c..71dc3050c285 100644 --- a/services/src/main/java/org/apache/druid/cli/CliPeon.java +++ b/services/src/main/java/org/apache/druid/cli/CliPeon.java @@ -381,7 +381,7 @@ public void run() } } catch (Throwable t) { - System.err.println("ERROR stopping!"); + System.err.println("Error!"); System.err.println(Throwables.getStackTraceAsString(t)); System.exit(1); }