From 3220a132175f6d56e1526e074da79ace8b53156d Mon Sep 17 00:00:00 2001 From: jon-wei Date: Thu, 23 May 2019 14:27:35 -0700 Subject: [PATCH] Fix dead code in IndexTask.collectIntervalsAndShardSpecs() --- .../apache/druid/indexing/common/task/IndexTask.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java index 5161f9bcba93..20cee242c229 100644 --- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java +++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java @@ -731,8 +731,6 @@ private Map> collectIntervalsAndShardSp final Map> hllCollectors = new TreeMap<>( Comparators.intervalsByStartThenEnd() ); - int thrownAway = 0; - int unparseable = 0; final Granularity queryGranularity = granularitySpec.getQueryGranularity(); try ( @@ -807,12 +805,13 @@ private Map> collectIntervalsAndShardSp } // These metrics are reported in generateAndPublishSegments() - if (thrownAway > 0) { - log.warn("Unable to find a matching interval for [%,d] events", thrownAway); + if (determinePartitionsMeters.getThrownAway() > 0) { + log.warn("Unable to find a matching interval for [%,d] events", determinePartitionsMeters.getThrownAway()); } - if (unparseable > 0) { - log.warn("Unable to parse [%,d] events", unparseable); + if (determinePartitionsMeters.getUnparseable() > 0) { + log.warn("Unable to parse [%,d] events", determinePartitionsMeters.getUnparseable()); } + return hllCollectors; }