diff --git a/processing/pom.xml b/processing/pom.xml
index ac3bdcf76670..883104152011 100644
--- a/processing/pom.xml
+++ b/processing/pom.xml
@@ -193,6 +193,12 @@
caliper
test
+
+ org.mockito
+ mockito-core
+ 3.2.4
+ test
+
nl.jqno.equalsverifier
equalsverifier
diff --git a/processing/src/main/java/org/apache/druid/segment/filter/cnf/CalciteCnfHelper.java b/processing/src/main/java/org/apache/druid/segment/filter/cnf/CalciteCnfHelper.java
index f857ae236a21..0685948a7e5e 100644
--- a/processing/src/main/java/org/apache/druid/segment/filter/cnf/CalciteCnfHelper.java
+++ b/processing/src/main/java/org/apache/druid/segment/filter/cnf/CalciteCnfHelper.java
@@ -59,9 +59,7 @@ public static Filter pull(Filter rex)
final List list = new ArrayList<>();
for (Filter operand : operands) {
Filter removed = removeFactor(factors, operand);
- if (removed != null) {
- list.add(removed);
- }
+ list.add(removed);
}
if (list.isEmpty()) {
return and(factors.values());
diff --git a/processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java b/processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
index 46f522c9ef8b..c854ac89c610 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
@@ -236,6 +236,7 @@ public Sequence makeCursors(
return Sequences.map(
baseCursorSequence,
cursor -> {
+ assert cursor != null;
Cursor retVal = cursor;
for (JoinableClause clause : clauses) {
diff --git a/processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java b/processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java
index dddd61814aea..69bb7af4714c 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java
@@ -79,7 +79,7 @@ private JoinConditionAnalysis(
.allMatch(expr -> expr.isLiteral() && expr.eval(
ExprUtils.nilBindings()).asBoolean());
canHashJoin = nonEquiConditions.stream().allMatch(Expr::isLiteral);
- rightKeyColumns = getEquiConditions().stream().map(Equality::getRightColumn).distinct().collect(Collectors.toSet());
+ rightKeyColumns = getEquiConditions().stream().map(Equality::getRightColumn).collect(Collectors.toSet());
}
/**
@@ -108,14 +108,18 @@ public static JoinConditionAnalysis forExpression(
nonEquiConditions.add(childExpr);
} else {
final Pair decomposed = maybeDecomposed.get();
- final Expr lhs = decomposed.lhs;
- final Expr rhs = decomposed.rhs;
+ final Expr lhs = Objects.requireNonNull(decomposed.lhs);
+ final Expr rhs = Objects.requireNonNull(decomposed.rhs);
if (isLeftExprAndRightColumn(lhs, rhs, rightPrefix)) {
// rhs is a right-hand column; lhs is an expression solely of the left-hand side.
- equiConditions.add(new Equality(lhs, rhs.getBindingIfIdentifier().substring(rightPrefix.length())));
+ equiConditions.add(
+ new Equality(lhs, Objects.requireNonNull(rhs.getBindingIfIdentifier()).substring(rightPrefix.length()))
+ );
} else if (isLeftExprAndRightColumn(rhs, lhs, rightPrefix)) {
- equiConditions.add(new Equality(rhs, lhs.getBindingIfIdentifier().substring(rightPrefix.length())));
+ equiConditions.add(
+ new Equality(rhs, Objects.requireNonNull(lhs.getBindingIfIdentifier()).substring(rightPrefix.length()))
+ );
} else {
nonEquiConditions.add(childExpr);
}
diff --git a/processing/src/main/java/org/apache/druid/segment/join/Joinable.java b/processing/src/main/java/org/apache/druid/segment/join/Joinable.java
index 7983f6fdb9c4..1ededff5e8b8 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/Joinable.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/Joinable.java
@@ -81,9 +81,9 @@ JoinMatcher makeJoinMatcher(
* Searches a column from this Joinable for a particular value, finds rows that match,
* and returns values of a second column for those rows.
*
- * @param searchColumnName Name of the search column
- * @param searchColumnValue Target value of the search column
- * @param retrievalColumnName The column to retrieve values from
+ * @param searchColumnName Name of the search column. This is the column that is being used in the filter
+ * @param searchColumnValue Target value of the search column. This is the value that is being filtered on.
+ * @param retrievalColumnName The column to retrieve values from. This is the column that is being joined against.
* @param maxCorrelationSetSize Maximum number of values to retrieve. If we detect that more values would be
* returned than this limit, return an empty set.
* @param allowNonKeyColumnSearch If true, allow searchs on non-key columns. If this is false,
diff --git a/processing/src/main/java/org/apache/druid/segment/join/PossiblyNullDimensionSelector.java b/processing/src/main/java/org/apache/druid/segment/join/PossiblyNullDimensionSelector.java
index b678b45a4c13..ab3fb87a2968 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/PossiblyNullDimensionSelector.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/PossiblyNullDimensionSelector.java
@@ -138,7 +138,10 @@ public int lookupId(@Nullable String name)
// id 0 is always null for this selector impl.
return 0;
} else {
- return baseSelector.idLookup().lookupId(name) + nullAdjustment;
+ IdLookup idLookup = baseSelector.idLookup();
+ // idLookup is null here because callers are expected to check this condition before calling lookupId
+ assert idLookup != null;
+ return idLookup.lookupId(name) + nullAdjustment;
}
}
diff --git a/processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java b/processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
index 69e3b230b0e8..7b2032f63aa8 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
@@ -38,6 +38,7 @@
import org.apache.druid.segment.join.JoinableClause;
import org.apache.druid.segment.virtual.ExpressionVirtualColumn;
+import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
@@ -175,9 +176,7 @@ public static JoinFilterPreAnalysis computeJoinFilterPreAnalysis(
for (Equality equality : clause.getCondition().getEquiConditions()) {
Set exprsForRhs = equiconditions.computeIfAbsent(
clause.getPrefix() + equality.getRightColumn(),
- (rhs) -> {
- return new HashSet<>();
- }
+ (rhs) -> new HashSet<>()
);
exprsForRhs.add(equality.getLeftExpr());
}
@@ -263,9 +262,7 @@ public static JoinFilterPreAnalysis computeJoinFilterPreAnalysis(
Optional> perColumnCorrelations =
correlationsByFilteringColumn.computeIfAbsent(
rhsRewriteCandidate.getRhsColumn(),
- (rhsCol) -> {
- return Optional.of(new ArrayList<>());
- }
+ (rhsCol) -> Optional.of(new ArrayList<>())
);
perColumnCorrelations.get().add(correlationForPrefix.getValue());
correlationForPrefix.getValue().getCorrelatedValuesMap().computeIfAbsent(
@@ -350,6 +347,7 @@ public static JoinFilterSplit splitFilter(
joinFilterPreAnalysis
);
if (joinFilterAnalysis.isCanPushDown()) {
+ //noinspection OptionalGetWithoutIsPresent isCanPushDown checks isPresent
leftFilters.add(joinFilterAnalysis.getPushDownFilter().get());
if (!joinFilterAnalysis.getPushDownVirtualColumns().isEmpty()) {
pushDownVirtualColumns.addAll(joinFilterAnalysis.getPushDownVirtualColumns());
@@ -438,6 +436,7 @@ private static JoinFilterAnalysis rewriteOrFilter(
if (!rewritten.isCanPushDown()) {
return JoinFilterAnalysis.createNoPushdownFilterAnalysis(orFilter);
} else {
+ //noinspection OptionalGetWithoutIsPresent isCanPushDown checks isPresent
newFilters.add(rewritten.getPushDownFilter().get());
}
} else {
@@ -762,6 +761,7 @@ private static boolean filterMatchesNull(Filter filter)
return valueMatcher.matches();
}
+ @Nullable
private static JoinableClause isColumnFromJoin(
List joinableClauses,
String column
diff --git a/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java b/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
index 15995b1c66c2..624b6bc408bc 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinMatcher.java
@@ -275,6 +275,7 @@ public void matchRemainder()
} else if (condition.isAlwaysTrue()) {
currentIterator = Collections.emptyIterator();
} else {
+ //noinspection ConstantConditions - entry can not be null because extractor.iterable() prevents this
currentIterator = Iterators.filter(
extractor.iterable().iterator(),
entry -> !matchedKeys.contains(entry.getKey())
diff --git a/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinable.java b/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinable.java
index 6b1b41a762dd..353808dd6b33 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinable.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/lookup/LookupJoinable.java
@@ -31,6 +31,7 @@
import org.apache.druid.segment.join.Joinable;
import javax.annotation.Nullable;
+import java.util.Collections;
import java.util.List;
import java.util.Set;
@@ -95,18 +96,23 @@ public Set getCorrelatedColumnValues(
boolean allowNonKeyColumnSearch
)
{
+ if (!ALL_COLUMNS.contains(searchColumnName) || !ALL_COLUMNS.contains(retrievalColumnName)) {
+ return ImmutableSet.of();
+ }
Set correlatedValues;
if (LookupColumnSelectorFactory.KEY_COLUMN.equals(searchColumnName)) {
if (LookupColumnSelectorFactory.KEY_COLUMN.equals(retrievalColumnName)) {
correlatedValues = ImmutableSet.of(searchColumnValue);
} else {
- correlatedValues = ImmutableSet.of(extractor.apply(searchColumnName));
+ // This should not happen in practice because the column to be joined on must be a key.
+ correlatedValues = Collections.singleton(extractor.apply(searchColumnValue));
}
} else {
if (!allowNonKeyColumnSearch) {
return ImmutableSet.of();
}
if (LookupColumnSelectorFactory.VALUE_COLUMN.equals(retrievalColumnName)) {
+ // This should not happen in practice because the column to be joined on must be a key.
correlatedValues = ImmutableSet.of(searchColumnValue);
} else {
// Lookup extractor unapply only provides a list of strings, so we can't respect
diff --git a/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableColumnValueSelector.java b/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableColumnValueSelector.java
index 814658cd0a29..5f6b07adbfdc 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableColumnValueSelector.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableColumnValueSelector.java
@@ -52,6 +52,7 @@ public double getDouble()
// Otherwise this shouldn't have been called (due to isNull returning true).
assert NullHandling.replaceWithDefault();
+ //noinspection ConstantConditions assert statement above guarantees this is non null.
return NullHandling.defaultDoubleValue();
}
@@ -70,6 +71,7 @@ public float getFloat()
// Otherwise this shouldn't have been called (due to isNull returning true).
assert NullHandling.replaceWithDefault();
+ //noinspection ConstantConditions assert statement above guarantees this is non null.
return NullHandling.defaultFloatValue();
}
@@ -88,6 +90,7 @@ public long getLong()
// Otherwise this shouldn't have been called (due to isNull returning true).
assert NullHandling.replaceWithDefault();
+ //noinspection ConstantConditions assert statement above guarantees this is non null.
return NullHandling.defaultLongValue();
}
diff --git a/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinable.java b/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinable.java
index 38cf5f89574b..a661b5ad21ce 100644
--- a/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinable.java
+++ b/processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinable.java
@@ -30,6 +30,7 @@
import javax.annotation.Nullable;
import java.util.HashSet;
import java.util.List;
+import java.util.Objects;
import java.util.Set;
public class IndexedTableJoinable implements Joinable
@@ -103,7 +104,8 @@ public Set getCorrelatedColumnValues(
IntList rowIndex = index.find(searchColumnValue);
for (int i = 0; i < rowIndex.size(); i++) {
int rowNum = rowIndex.getInt(i);
- correlatedValues.add(reader.read(rowNum).toString());
+ String correlatedDimVal = Objects.toString(reader.read(rowNum), null);
+ correlatedValues.add(correlatedDimVal);
if (correlatedValues.size() > maxCorrelationSetSize) {
return ImmutableSet.of();
@@ -118,11 +120,13 @@ public Set getCorrelatedColumnValues(
IndexedTable.Reader dimNameReader = table.columnReader(filterColumnPosition);
IndexedTable.Reader correlatedColumnReader = table.columnReader(correlatedColumnPosition);
for (int i = 0; i < table.numRows(); i++) {
- if (searchColumnValue.equals(dimNameReader.read(i).toString())) {
- correlatedValues.add(correlatedColumnReader.read(i).toString());
- }
- if (correlatedValues.size() > maxCorrelationSetSize) {
- return ImmutableSet.of();
+ String dimVal = Objects.toString(dimNameReader.read(i), null);
+ if (searchColumnValue.equals(dimVal)) {
+ String correlatedDimVal = Objects.toString(correlatedColumnReader.read(i), null);
+ correlatedValues.add(correlatedDimVal);
+ if (correlatedValues.size() > maxCorrelationSetSize) {
+ return ImmutableSet.of();
+ }
}
}
diff --git a/processing/src/main/java/org/apache/druid/segment/transform/Transformer.java b/processing/src/main/java/org/apache/druid/segment/transform/Transformer.java
index 48b0421c7b87..47d89b26197b 100644
--- a/processing/src/main/java/org/apache/druid/segment/transform/Transformer.java
+++ b/processing/src/main/java/org/apache/druid/segment/transform/Transformer.java
@@ -156,6 +156,7 @@ public long getTimestampFromEpoch()
{
final RowFunction transform = transforms.get(ColumnHolder.TIME_COLUMN_NAME);
if (transform != null) {
+ //noinspection ConstantConditions time column is never null
return Rows.objectToNumber(ColumnHolder.TIME_COLUMN_NAME, transform.eval(row), true).longValue();
} else {
return row.getTimestampFromEpoch();
diff --git a/processing/src/main/java/org/apache/druid/segment/vector/QueryableIndexVectorColumnSelectorFactory.java b/processing/src/main/java/org/apache/druid/segment/vector/QueryableIndexVectorColumnSelectorFactory.java
index 83110499862f..d8165895511d 100644
--- a/processing/src/main/java/org/apache/druid/segment/vector/QueryableIndexVectorColumnSelectorFactory.java
+++ b/processing/src/main/java/org/apache/druid/segment/vector/QueryableIndexVectorColumnSelectorFactory.java
@@ -96,6 +96,8 @@ public MultiValueDimensionVectorSelector makeMultiValueDimensionSelector(final D
final DictionaryEncodedColumn dictionaryEncodedColumn = (DictionaryEncodedColumn)
getCachedColumn(spec.getDimension());
+ // dictionaryEncodedColumn is not null because of holder null check above
+ assert dictionaryEncodedColumn != null;
final MultiValueDimensionVectorSelector selector = dictionaryEncodedColumn.makeMultiValueDimensionVectorSelector(
offset
);
@@ -132,6 +134,8 @@ public SingleValueDimensionVectorSelector makeSingleValueDimensionSelector(final
final DictionaryEncodedColumn dictionaryEncodedColumn = (DictionaryEncodedColumn)
getCachedColumn(spec.getDimension());
+ // dictionaryEncodedColumn is not null because of holder null check above
+ assert dictionaryEncodedColumn != null;
final SingleValueDimensionVectorSelector selector =
dictionaryEncodedColumn.makeSingleValueDimensionVectorSelector(offset);
diff --git a/processing/src/main/java/org/apache/druid/segment/virtual/MultiValueExpressionDimensionSelector.java b/processing/src/main/java/org/apache/druid/segment/virtual/MultiValueExpressionDimensionSelector.java
index e3b5734ee62f..513631e5e791 100644
--- a/processing/src/main/java/org/apache/druid/segment/virtual/MultiValueExpressionDimensionSelector.java
+++ b/processing/src/main/java/org/apache/druid/segment/virtual/MultiValueExpressionDimensionSelector.java
@@ -55,6 +55,7 @@ ExprEval getEvaluated()
return baseSelector.getObject();
}
+ @Nullable
String getValue(ExprEval evaluated)
{
assert !evaluated.isArray();
@@ -64,15 +65,18 @@ String getValue(ExprEval evaluated)
List getArray(ExprEval evaluated)
{
assert evaluated.isArray();
+ //noinspection ConstantConditions
return Arrays.stream(evaluated.asStringArray())
.map(NullHandling::emptyToNullIfNeeded)
.collect(Collectors.toList());
}
+ @Nullable
String getArrayValue(ExprEval evaluated, int i)
{
assert evaluated.isArray();
String[] stringArray = evaluated.asStringArray();
+ //noinspection ConstantConditions because of assert statement above
assert i < stringArray.length;
return NullHandling.emptyToNullIfNeeded(stringArray[i]);
}
@@ -83,7 +87,8 @@ public IndexedInts getRow()
ExprEval evaluated = getEvaluated();
if (evaluated.isArray()) {
RangeIndexedInts ints = new RangeIndexedInts();
- ints.setSize(evaluated.asArray() != null ? evaluated.asArray().length : 0);
+ Object[] evaluatedArray = evaluated.asArray();
+ ints.setSize(evaluatedArray != null ? evaluatedArray.length : 0);
return ints;
}
return ZeroIndexedInts.instance();
diff --git a/processing/src/main/java/org/apache/druid/segment/virtual/SingleInputBindings.java b/processing/src/main/java/org/apache/druid/segment/virtual/SingleInputBindings.java
index eecc9feaf61b..2525e09d3d45 100644
--- a/processing/src/main/java/org/apache/druid/segment/virtual/SingleInputBindings.java
+++ b/processing/src/main/java/org/apache/druid/segment/virtual/SingleInputBindings.java
@@ -25,6 +25,7 @@
public class SingleInputBindings implements Expr.ObjectBinding
{
+ @Nullable
private Object value;
@Override
diff --git a/processing/src/test/java/org/apache/druid/segment/join/lookup/LookupJoinableTest.java b/processing/src/test/java/org/apache/druid/segment/join/lookup/LookupJoinableTest.java
new file mode 100644
index 000000000000..4115b84acec2
--- /dev/null
+++ b/processing/src/test/java/org/apache/druid/segment/join/lookup/LookupJoinableTest.java
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.segment.join.lookup;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
+import org.apache.druid.query.lookup.LookupExtractor;
+import org.apache.druid.segment.column.ColumnCapabilities;
+import org.apache.druid.segment.column.ValueType;
+import org.apache.druid.segment.join.Joinable;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+
+@RunWith(MockitoJUnitRunner.class)
+public class LookupJoinableTest
+{
+ private static final String UNKNOWN_COLUMN = "UNKNOWN_COLUMN";
+ private static final String SEARCH_KEY_VALUE = "SEARCH_KEY_VALUE";
+ private static final String SEARCH_KEY_NULL_VALUE = "SEARCH_KEY_NULL_VALUE";
+ private static final String SEARCH_VALUE_VALUE = "SEARCH_VALUE_VALUE";
+ private static final String SEARCH_VALUE_UNKNOWN = "SEARCH_VALUE_UNKNOWN";
+
+ @Mock
+ private LookupExtractor extractor;
+
+ private LookupJoinable target;
+
+ @Before
+ public void setUp()
+ {
+ Mockito.doReturn(SEARCH_VALUE_VALUE).when(extractor).apply(SEARCH_KEY_VALUE);
+ Mockito.doReturn(ImmutableList.of(SEARCH_KEY_VALUE)).when(extractor).unapply(SEARCH_VALUE_VALUE);
+ Mockito.doReturn(ImmutableList.of()).when(extractor).unapply(SEARCH_VALUE_UNKNOWN);
+ target = LookupJoinable.wrap(extractor);
+ }
+
+ @Test
+ public void getAvailableColumnShouldReturnOnlyTwoColumns()
+ {
+ List colummns = target.getAvailableColumns();
+ Assert.assertEquals(2, colummns.size());
+ Assert.assertEquals(
+ ImmutableList.of(LookupColumnSelectorFactory.KEY_COLUMN, LookupColumnSelectorFactory.VALUE_COLUMN),
+ colummns
+ );
+ }
+
+ @Test
+ public void getCardinalityForUnknownColumnShouldReturnUnknown()
+ {
+ int cardinality = target.getCardinality(UNKNOWN_COLUMN);
+ Assert.assertEquals(Joinable.CARDINALITY_UNKNOWN, cardinality);
+ }
+
+ @Test
+ public void getCardinalityForKeyColumnShouldReturnUnknown()
+ {
+ int cardinality = target.getCardinality(LookupColumnSelectorFactory.KEY_COLUMN);
+ Assert.assertEquals(Joinable.CARDINALITY_UNKNOWN, cardinality);
+ }
+
+ @Test
+ public void getCardinalityForValueColumnShouldReturnUnknown()
+ {
+ int cardinality = target.getCardinality(LookupColumnSelectorFactory.VALUE_COLUMN);
+ Assert.assertEquals(Joinable.CARDINALITY_UNKNOWN, cardinality);
+ }
+
+ @Test
+ public void getColumnCapabilitiesForKeyColumnShouldReturnStringCaps()
+ {
+ ColumnCapabilities capabilities = target.getColumnCapabilities(LookupColumnSelectorFactory.KEY_COLUMN);
+ Assert.assertEquals(ValueType.STRING, capabilities.getType());
+ }
+
+ @Test
+ public void getColumnCapabilitiesForValueColumnShouldReturnStringCaps()
+ {
+ ColumnCapabilities capabilities = target.getColumnCapabilities(LookupColumnSelectorFactory.VALUE_COLUMN);
+ Assert.assertEquals(ValueType.STRING, capabilities.getType());
+ }
+
+ @Test
+ public void getColumnCapabilitiesForUnknownColumnShouldReturnNull()
+ {
+ ColumnCapabilities capabilities = target.getColumnCapabilities(UNKNOWN_COLUMN);
+ Assert.assertNull(capabilities);
+ }
+
+ @Test
+ public void getCorrelatedColummnValuesMissingSearchColumnShouldReturnEmptySet()
+ {
+ Set correlatedValues =
+ target.getCorrelatedColumnValues(
+ UNKNOWN_COLUMN,
+ SEARCH_KEY_VALUE,
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ 0,
+ false);
+
+ Assert.assertEquals(Collections.emptySet(), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColummnValuesMissingRetrievalColumnShouldReturnEmptySet()
+ {
+ Set correlatedValues =
+ target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ SEARCH_KEY_VALUE,
+ UNKNOWN_COLUMN,
+ 0,
+ false);
+
+ Assert.assertEquals(Collections.emptySet(), correlatedValues);
+ }
+ @Test
+ public void getCorrelatedColumnValuesForSearchKeyAndRetrieveKeyColumnShouldReturnSearchValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ SEARCH_KEY_VALUE,
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ 0,
+ false);
+ Assert.assertEquals(ImmutableSet.of(SEARCH_KEY_VALUE), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchKeyAndRetrieveValueColumnShouldReturnExtractedValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ SEARCH_KEY_VALUE,
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ 0,
+ false);
+ Assert.assertEquals(ImmutableSet.of(SEARCH_VALUE_VALUE), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchKeyMissingAndRetrieveValueColumnShouldReturnExtractedValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ SEARCH_KEY_NULL_VALUE,
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ 0,
+ false);
+ Assert.assertEquals(Collections.singleton(null), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchValueAndRetrieveValueColumnAndNonKeyColumnSearchDisabledShouldReturnSearchValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_VALUE,
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ 10,
+ false);
+ Assert.assertEquals(ImmutableSet.of(), correlatedValues);
+ correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_VALUE,
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ 10,
+ false);
+ Assert.assertEquals(ImmutableSet.of(), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchValueAndRetrieveValueColumnShouldReturnSearchValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_VALUE,
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ 0,
+ true);
+ Assert.assertEquals(ImmutableSet.of(SEARCH_VALUE_VALUE), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchValueAndRetrieveKeyColumnShouldReturnUnAppliedValue()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_VALUE,
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ 10,
+ true);
+ Assert.assertEquals(ImmutableSet.of(SEARCH_KEY_VALUE), correlatedValues);
+ }
+
+ @Test
+ @Ignore
+ /**
+ * See {@link LookupJoinable#getCorrelatedColumnValues(String, String, String, long, boolean)} for implementation
+ * details that cause this test to fail.
+ */
+ public void getCorrelatedColumnValuesForSearchValueAndRetrieveKeyColumnWithMaxLimitSetShouldHonorMaxLimit()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_VALUE,
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ 0,
+ true);
+ Assert.assertEquals(ImmutableSet.of(), correlatedValues);
+ }
+
+ @Test
+ public void getCorrelatedColumnValuesForSearchUnknownValueAndRetrieveKeyColumnShouldReturnNoCorrelatedValues()
+ {
+ Set correlatedValues = target.getCorrelatedColumnValues(
+ LookupColumnSelectorFactory.VALUE_COLUMN,
+ SEARCH_VALUE_UNKNOWN,
+ LookupColumnSelectorFactory.KEY_COLUMN,
+ 10,
+ true);
+ Assert.assertEquals(ImmutableSet.of(), correlatedValues);
+ }
+}
diff --git a/processing/src/test/java/org/apache/druid/segment/join/table/IndexedTableJoinableTest.java b/processing/src/test/java/org/apache/druid/segment/join/table/IndexedTableJoinableTest.java
index e8e3be4e5d00..89f78dc523d2 100644
--- a/processing/src/test/java/org/apache/druid/segment/join/table/IndexedTableJoinableTest.java
+++ b/processing/src/test/java/org/apache/druid/segment/join/table/IndexedTableJoinableTest.java
@@ -36,11 +36,23 @@
import org.apache.druid.segment.join.JoinConditionAnalysis;
import org.apache.druid.segment.join.JoinMatcher;
import org.junit.Assert;
+import org.junit.Before;
import org.junit.Test;
+import java.util.Collections;
+import java.util.Set;
+
public class IndexedTableJoinableTest
{
private static final String PREFIX = "j.";
+ private static final String KEY_COLUMN = "str";
+ private static final String VALUE_COLUMN = "long";
+ private static final String UNKNOWN_COLUMN = "unknown";
+ private static final String SEARCH_KEY_NULL_VALUE = "baz";
+ private static final String SEARCH_KEY_VALUE = "foo";
+ private static final String SEARCH_VALUE_VALUE = "1";
+ private static final String SEARCH_VALUE_UNKNOWN = "10";
+ private static final long MAX_CORRELATION_SET_SIZE = 10_000L;
static {
NullHandling.initializeForTests();
@@ -70,9 +82,13 @@ public ColumnCapabilities getColumnCapabilities(String columnName)
private final InlineDataSource inlineDataSource = InlineDataSource.fromIterable(
ImmutableList.of(
new Object[]{"foo", 1L},
- new Object[]{"bar", 2L}
+ new Object[]{"bar", 2L},
+ new Object[]{"baz", null}
),
- RowSignature.builder().add("str", ValueType.STRING).add("long", ValueType.LONG).build()
+ RowSignature.builder()
+ .add("str", ValueType.STRING)
+ .add("long", ValueType.LONG)
+ .build()
);
private final RowBasedIndexedTable