Skip to content

doc: add doc for coarse-pointer#67

Merged
Ovilia merged 3 commits into
masterfrom
doc-coarse-pointer
Sep 20, 2022
Merged

doc: add doc for coarse-pointer#67
Ovilia merged 3 commits into
masterfrom
doc-coarse-pointer

Conversation

@Ovilia
Copy link
Copy Markdown
Contributor

@Ovilia Ovilia commented Sep 20, 2022

Add doc for coarse pointer apache/echarts#17102 .

Copy link
Copy Markdown
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make it clear on the usage of intersect & interact and interactable & interactive and keep them consistent. In my view, interactable is less used than interactive. Correct me if I'm wrong.

Comment thread contents/en/how-to/interaction/coarse-pointer.md Outdated
Comment thread contents/en/how-to/interaction/coarse-pointer.md
src="images/how-to/coarse-pointer-en.gif">
</img>

That is, if an element is within the `opt.pointerSize` radius of the mouse or touch position, the closest interactable element is considered the interactive object.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactable seems less used and it's better to use interactive for consistency.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I was using Google Translation and did not pay much attention to the difference between interactive and interactable. After a second thought, I think interactable can mean something can be interacted with (可交互的) while interactive is the adjective form of interaction (交互的). But I do like the idea to keep it simple so I changed all to be interactive.

Comment thread contents/en/how-to/interaction/coarse-pointer.md Outdated
Copy link
Copy Markdown
Member

@100pah 100pah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ovilia Ovilia merged commit 8c87c63 into master Sep 20, 2022
@Ovilia Ovilia deleted the doc-coarse-pointer branch September 20, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants