From d7786c52c49bccb1b8c78989ef5e4d29348543fa Mon Sep 17 00:00:00 2001 From: yuanjiangxia <511217468@qq.com> Date: Wed, 23 Mar 2022 17:53:33 +0800 Subject: [PATCH] fix(dataZoom): fix the dataZoom was unexpectedly displayed at the top when data contains null values. --- src/data/DataStore.ts | 8 ++- test/dataZoom-feature.html | 112 ++++++++++++++++++++++++++++++++++++- 2 files changed, 116 insertions(+), 4 deletions(-) diff --git a/src/data/DataStore.ts b/src/data/DataStore.ts index ddd3c09a44..4ceb7ba894 100644 --- a/src/data/DataStore.ts +++ b/src/data/DataStore.ts @@ -290,8 +290,10 @@ class DataStore { // Parse from previous data offset. len may be changed after appendData for (let i = offset; i < len; i++) { const val = (chunk as any)[i] = ordinalMeta.parseAndCollect(chunk[i]); - dimRawExtent[0] = Math.min(val, dimRawExtent[0]); - dimRawExtent[1] = Math.max(val, dimRawExtent[1]); + if (!isNaN(val)) { + dimRawExtent[0] = Math.min(val, dimRawExtent[0]); + dimRawExtent[1] = Math.max(val, dimRawExtent[1]); + } } dim.ordinalMeta = ordinalMeta; @@ -1308,4 +1310,4 @@ class DataStore { })(); } -export default DataStore; \ No newline at end of file +export default DataStore; diff --git a/test/dataZoom-feature.html b/test/dataZoom-feature.html index 8f2b5b0e97..6715089fd0 100644 --- a/test/dataZoom-feature.html +++ b/test/dataZoom-feature.html @@ -43,7 +43,7 @@
- +
@@ -746,6 +746,116 @@ }); + +