Skip to content

chore(lint): enforce consistent spacing after comment starts#17606

Merged
Ovilia merged 1 commit into
masterfrom
fix-lint
Sep 23, 2022
Merged

chore(lint): enforce consistent spacing after comment starts#17606
Ovilia merged 1 commit into
masterfrom
fix-lint

Conversation

@Ovilia
Copy link
Copy Markdown
Contributor

@Ovilia Ovilia commented Sep 2, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Disallow comments starting without space. For example: //This is not allowed.

Fixed issues

Details

Before: What was the problem?

Sometimes contributors forget to add a space after comment starts.

After: How does it behave after the fixing?

The CI will break if there is no space after a comment starts.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Sep 2, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia merged commit 9c00766 into master Sep 23, 2022
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Sep 23, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-lint branch September 23, 2022 01:52
@Ovilia Ovilia removed this from the 5.4.1 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants