Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc-common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ rules:
- 2
- "never"
space-unary-ops: 2
spaced-comment: 0
spaced-comment: "error"

max-nested-callbacks:
- 1
Expand Down
2 changes: 1 addition & 1 deletion src/coord/axisHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export function getScaleExtent(scale: Scale, model: AxisBaseModel) {
// (4) Consider other chart types using `barGrid`?
// See #6728, #4862, `test/bar-overflow-time-plot.html`
const ecModel = model.ecModel;
if (ecModel && (scaleType === 'time' /*|| scaleType === 'interval' */)) {
if (ecModel && (scaleType === 'time' /* || scaleType === 'interval' */)) {
const barSeriesModels = prepareLayoutBarSeries('bar', ecModel);
let isBaseAxisAndHasBarSeries = false;

Expand Down
2 changes: 1 addition & 1 deletion src/core/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ const iterator: TaskDataIterator = (function () {



///////////////////////////////////////////////////////////
// -----------------------------------------------------------------------------
// For stream debug (Should be commented out after used!)
// @usage: printTask(this, 'begin');
// @usage: printTask(this, null, {someExtraProp});
Expand Down
6 changes: 3 additions & 3 deletions src/export/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export {use} from '../extension';

export {setPlatformAPI} from 'zrender/src/core/platform';

//////////////// Helper Methods /////////////////////
// --------------------- Helper Methods ---------------------
export {default as parseGeoJSON} from '../coord/geo/parseGeoJson';
export {default as parseGeoJson} from '../coord/geo/parseGeoJson';

Expand All @@ -55,7 +55,7 @@ export * as util from './api/util';

export {default as env} from 'zrender/src/core/env';

//////////////// Export for Exension Usage ////////////////
// --------------------- Export for Exension Usage ---------------------
// export {SeriesData};
export {SeriesData as List}; // TODO: Compatitable with exists echarts-gl code
export {default as Model} from '../model/Model';
Expand All @@ -72,7 +72,7 @@ export {
export {brushSingle as innerDrawElementOnCanvas} from 'zrender/src/canvas/graphic';


//////////////// Deprecated Extension Methods ////////////////
// --------------------- Deprecated Extension Methods ---------------------

// Should use `ComponentModel.extend` or `class XXXX extend ComponentModel` to create class.
// Then use `registerComponentModel` in `install` parameter when `use` this extension. For example:
Expand Down
2 changes: 1 addition & 1 deletion src/layout/barPolar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function barLayoutPolar(seriesType: string, ecModel: GlobalModel, api: Extension

const valueDim = data.mapDimension(valueAxis.dim);
const baseDim = data.mapDimension(baseAxis.dim);
const stacked = isDimensionStacked(data, valueDim /*, baseDim*/);
const stacked = isDimensionStacked(data, valueDim /* , baseDim */);
const clampLayout = baseAxis.dim !== 'radius'
|| !seriesModel.get('roundCap', true);

Expand Down
3 changes: 2 additions & 1 deletion src/util/states.ts
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,8 @@ function elementStateProxy(this: Displayable, stateName: string, targetStates?:
}
return state;
}
/**FI

/**
* Set hover style (namely "emphasis style") of element.
* @param el Should not be `zrender/graphic/Group`.
* @param focus 'self' | 'selfInSeries' | 'series'
Expand Down
3 changes: 2 additions & 1 deletion src/util/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,8 @@ export type ComponentLayoutMode = {
type?: 'box',
ignoreSize?: boolean | boolean[]
};
/******************* Mixins for Common Option Properties ********************** */

// ------------------ Mixins for Common Option Properties ------------------
export type PaletteOptionMixin = ColorPaletteOptionMixin;

export interface ColorPaletteOptionMixin {
Expand Down