From 98cc3ff7711485d997636cf9df9f3d41015b3c8e Mon Sep 17 00:00:00 2001 From: glutenperfbot Date: Sat, 6 Sep 2025 08:32:15 +0000 Subject: [PATCH 1/2] [GLUTEN-6887][VL] Daily Update Velox Version (2025_09_06) Upstream Velox's New Commits: 2cac6c685 by Devavret Makkar, feat(cudf): Add support for Nested precompute expressions cardinality and split (#14462) 1aff02aae by Daniel Munoz, misc: Update runtime metrics documentation (#14751) 99a04b94e by Jialiang Tan, misc: Remove SerializedPageSpiller related code/1 (#14683) d70eec6f0 by Masha Basmanova, feat: Allow adding per-node context to plan summary (#14742) 3f7a211f3 by Chengcheng Jin, feat(iceberg): Add bucket function (#13174) 2599eef30 by dependabot[bot], build(deps): Bump http-proxy-middleware from 2.0.7 to 2.0.9 in /website (#14708) d8433ba5e by Sutou Kouhei, fix(build): Fix wrong link target for velox_dwio_text_reader (#14674) 3721fe85e by Ke Jia, fix: Enable S3 and GCS unit tests (#14718) c12e666f8 by Mahadevuni Naveen Kumar, fix: Aggregate destroyAccumulator memset call with dynamic class input (#14568) Signed-off-by: glutenperfbot --- ep/build-velox/src/get_velox.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ep/build-velox/src/get_velox.sh b/ep/build-velox/src/get_velox.sh index 2cd318001862..76696022ea83 100755 --- a/ep/build-velox/src/get_velox.sh +++ b/ep/build-velox/src/get_velox.sh @@ -17,11 +17,11 @@ set -exu VELOX_REPO=https://github.com/oap-project/velox.git -VELOX_BRANCH=2025_09_04 +VELOX_BRANCH=2025_09_06 VELOX_HOME="" RUN_SETUP_SCRIPT=ON VELOX_ENHANCED_REPO=https://github.com/IBM/velox.git -VELOX_ENHANCED_BRANCH=ibm-2025_09_04 +VELOX_ENHANCED_BRANCH=ibm-2025_09_06 ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. From 8706d059f256abf31460ee9b9aac8f09e9fc7728 Mon Sep 17 00:00:00 2001 From: Yuan Date: Fri, 5 Sep 2025 20:46:28 +0100 Subject: [PATCH 2/2] fix memory manager api Signed-off-by: Yuan fix Signed-off-by: Yuan fix Signed-off-by: Yuan --- cpp/velox/compute/VeloxBackend.cc | 4 +++- cpp/velox/memory/VeloxMemoryManager.cc | 16 ++++++++-------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/cpp/velox/compute/VeloxBackend.cc b/cpp/velox/compute/VeloxBackend.cc index d8089d865369..04faab8f3ac5 100644 --- a/cpp/velox/compute/VeloxBackend.cc +++ b/cpp/velox/compute/VeloxBackend.cc @@ -210,7 +210,9 @@ void VeloxBackend::init( memoryManagerCapacity = facebook::velox::memory::kMaxMemory; } LOG(INFO) << "Setting global Velox memory manager with capacity: " << memoryManagerCapacity; - facebook::velox::memory::initializeMemoryManager({.allocatorCapacity = memoryManagerCapacity}); + facebook::velox::memory::MemoryManager::Options options; + options.allocatorCapacity = memoryManagerCapacity; + facebook::velox::memory::initializeMemoryManager(options); // local cache persistent relies on the cache pool from root memory pool so we need to init this // after the memory manager instanced diff --git a/cpp/velox/memory/VeloxMemoryManager.cc b/cpp/velox/memory/VeloxMemoryManager.cc index 840f4ca7952b..ec568fa6a6dd 100644 --- a/cpp/velox/memory/VeloxMemoryManager.cc +++ b/cpp/velox/memory/VeloxMemoryManager.cc @@ -234,14 +234,14 @@ VeloxMemoryManager::VeloxMemoryManager( auto checkUsageLeak = backendConf.get(kCheckUsageLeak, kCheckUsageLeakDefault); ArbitratorFactoryRegister afr(listener_.get()); - velox::memory::MemoryManagerOptions mmOptions{ - .alignment = velox::memory::MemoryAllocator::kMaxAlignment, - .trackDefaultUsage = true, // memory usage tracking - .checkUsageLeak = checkUsageLeak, // leak check - .coreOnAllocationFailureEnabled = false, - .allocatorCapacity = velox::memory::kMaxMemory, - .arbitratorKind = afr.getKind(), - .extraArbitratorConfigs = getExtraArbitratorConfigs(backendConf)}; + velox::memory::MemoryManager::Options mmOptions; + mmOptions.alignment = velox::memory::MemoryAllocator::kMaxAlignment; + mmOptions.trackDefaultUsage = true; // memory usage tracking + mmOptions.checkUsageLeak = checkUsageLeak; // leak check + mmOptions.coreOnAllocationFailureEnabled = false; + mmOptions.allocatorCapacity = velox::memory::kMaxMemory; + mmOptions.arbitratorKind = afr.getKind(); + mmOptions.extraArbitratorConfigs = getExtraArbitratorConfigs(backendConf); veloxMemoryManager_ = std::make_unique(mmOptions); veloxAggregatePool_ = veloxMemoryManager_->addRootPool(