From c141373289572e89028f7e7554ab105c5c57c84c Mon Sep 17 00:00:00 2001 From: Murtaza Hassan Date: Mon, 27 May 2019 12:55:23 +0200 Subject: [PATCH 1/3] HBASE-22482 Fix tag Warings in TestPartitionedMobCompactor --- .../mob/compactions/TestPartitionedMobCompactor.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java index 2cf741ed9bd6..f1557d25c7ab 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java @@ -811,10 +811,10 @@ private void compareDelFiles(List delPartitions) { /** * Creates store files. * @param basePath the path to create file - * @family the family name - * @qualifier the column qualifier - * @count the store file number - * @type the key type + * @param family the family name + * @param qualifier the column qualifier + * @param count the store file number + * @param type the key type */ private void createStoreFiles(Path basePath, String family, String qualifier, int count, Type type, final Date date) throws IOException { From 662c79ca493ffd6b02a749d63dd8213073cc7e27 Mon Sep 17 00:00:00 2001 From: Murtaza Hassan Date: Mon, 27 May 2019 14:59:41 +0200 Subject: [PATCH 2/3] HBASE-22482 Fix tag Warings in TestPartitionedMobCompactor, added date parameter in javadoc --- .../hbase/mob/compactions/TestPartitionedMobCompactor.java | 1 + 1 file changed, 1 insertion(+) diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java index f1557d25c7ab..18aba8c4c510 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java @@ -815,6 +815,7 @@ private void compareDelFiles(List delPartitions) { * @param qualifier the column qualifier * @param count the store file number * @param type the key type + * @param date the date value */ private void createStoreFiles(Path basePath, String family, String qualifier, int count, Type type, final Date date) throws IOException { From dd13b028e53652a3637c5939204e478c499a9877 Mon Sep 17 00:00:00 2001 From: Murtaza Hassan Date: Fri, 7 Jun 2019 16:38:30 +0200 Subject: [PATCH 3/3] HBASE-22482 Fix tag Warnings in TestPartitionedMobCompactor; added description for parameters --- .../mob/compactions/TestPartitionedMobCompactor.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java index 18aba8c4c510..4e6461aaf800 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestPartitionedMobCompactor.java @@ -811,11 +811,11 @@ private void compareDelFiles(List delPartitions) { /** * Creates store files. * @param basePath the path to create file - * @param family the family name - * @param qualifier the column qualifier + * @param family the column family name + * @param qualifier the column qualifier assigned to data values * @param count the store file number - * @param type the key type - * @param date the date value + * @param type the row key type + * @param date the latest timestamp when an instance of MobFileName is created */ private void createStoreFiles(Path basePath, String family, String qualifier, int count, Type type, final Date date) throws IOException {