From 277b1e328bfe5d288719ead26cf6c9fccd0cf3af Mon Sep 17 00:00:00 2001
From: narges <n.shadab94@gmail.com>
Date: Thu, 4 Mar 2021 11:58:50 -0800
Subject: [PATCH] close the BufferReader in the finally block

---
 .../HeterogeneousRegionCountCostFunction.java         | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java
index a9bb6851ad26..4b58b5d0d126 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java
@@ -221,11 +221,14 @@ private List<String> readFileFromLocalFS(final String filename) throws IOExcepti
 
   private List<String> readLines(BufferedReader reader) throws IOException {
     final List<String> records = new ArrayList<>();
-    String line;
-    while ((line = reader.readLine()) != null) {
-      records.add(line);
+    try {
+      String line;
+      while ((line = reader.readLine()) != null) {
+        records.add(line);
+      }
+    } finally {
+      reader.close();
     }
-    reader.close();
     return records;
   }