From d0ee260e1884368fe626a53b527d6a766cb44ad5 Mon Sep 17 00:00:00 2001
From: Almog Tavor <70065337+almogtavor@users.noreply.github.com>
Date: Tue, 29 Jun 2021 02:19:10 +0300
Subject: [PATCH] Remove redundant comparison

---
 .../hbase/regionserver/MetricsRegionSourceImpl.java       | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
index 40df2eef63d5..2f7f8074c9df 100644
--- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
+++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
@@ -180,13 +180,7 @@ public int compareTo(MetricsRegionSource source) {
     if (!(source instanceof MetricsRegionSourceImpl)) {
       return -1;
     }
-
-    MetricsRegionSourceImpl impl = (MetricsRegionSourceImpl) source;
-    if (impl == null) {
-      return -1;
-    }
-
-    return Long.compare(hashCode, impl.hashCode);
+    return Long.compare(hashCode, ((MetricsRegionSourceImpl) source).hashCode);
   }
 
   void snapshot(MetricsRecordBuilder mrb, boolean ignored) {