From fe7bfff96bcd29e0a826deceaf2444d94008741f Mon Sep 17 00:00:00 2001 From: skysiders Date: Sun, 1 May 2022 15:32:32 +0800 Subject: [PATCH] fix permission bugs --- .../hadoop/hbase/master/MasterFileSystem.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java index ca7eb909859b..2c4b897a1d02 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java @@ -343,17 +343,17 @@ private void checkSubDir(final Path p, final String dirPermsConfName) throws IOE } } } - else { - if (isSecurityEnabled && !dirPerms.equals(fs.getFileStatus(p).getPermission())) { - // check whether the permission match - LOG.warn("Found HBase directory permissions NOT matching expected permissions for " - + p.toString() + " permissions=" + fs.getFileStatus(p).getPermission() - + ", expecting " + dirPerms + ". Automatically setting the permissions. " - + "You can change the permissions by setting \"" + dirPermsConfName + "\" in hbase-site.xml " - + "and restarting the master"); - fs.setPermission(p, dirPerms); - } + + if (isSecurityEnabled && !dirPerms.equals(fs.getFileStatus(p).getPermission())) { + // check whether the permission match + LOG.warn("Found HBase directory permissions NOT matching expected permissions for " + + p.toString() + " permissions=" + fs.getFileStatus(p).getPermission() + + ", expecting " + dirPerms + ". Automatically setting the permissions. " + + "You can change the permissions by setting \"" + dirPermsConfName + "\" in hbase-site.xml " + + "and restarting the master"); + fs.setPermission(p, dirPerms); } + } /** @@ -368,9 +368,9 @@ private void checkStagingDir() throws IOException { if (!this.fs.mkdirs(p, HiddenDirPerms)) { throw new IOException("Failed to create staging directory " + p.toString()); } - } else { - this.fs.setPermission(p, HiddenDirPerms); } + this.fs.setPermission(p, HiddenDirPerms); + } catch (IOException e) { LOG.error("Failed to create or set permission on staging directory " + p.toString()); throw new IOException("Failed to create or set permission on staging directory "