From b3ad4907d25610fab4c5112cda985047d40447a7 Mon Sep 17 00:00:00 2001 From: Briana Augenreich Date: Wed, 30 Nov 2022 11:24:50 -0500 Subject: [PATCH 1/2] HBASE-27494 - fix missing cacheDroppingException metrics --- .../apache/hadoop/hbase/client/AsyncRequestFutureImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java index a91fd5af6af2..34fd58c9eeb0 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java @@ -912,6 +912,10 @@ private void cleanServerCache(ServerName server, Throwable regionException) { if (ClientExceptionsUtil.isMetaClearingException(regionException)) { // We want to make sure to clear the cache in case there were location-related exceptions. // We don't to clear the cache for every possible exception that comes through, however. + MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics(); + if (metrics != null){ + metrics.incrCacheDroppingExceptions(regionException); + } asyncProcess.connection.clearCaches(server); } } From 1a6e38f144def60951b9c7cab698ac1168399046 Mon Sep 17 00:00:00 2001 From: Briana Augenreich Date: Wed, 30 Nov 2022 11:30:09 -0500 Subject: [PATCH 2/2] Spotless --- .../org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java index 34fd58c9eeb0..bcc7fac32090 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java @@ -913,7 +913,7 @@ private void cleanServerCache(ServerName server, Throwable regionException) { // We want to make sure to clear the cache in case there were location-related exceptions. // We don't to clear the cache for every possible exception that comes through, however. MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics(); - if (metrics != null){ + if (metrics != null) { metrics.incrCacheDroppingExceptions(regionException); } asyncProcess.connection.clearCaches(server);