From 704e435294e16fcdf862ee7ce4afda23780dd085 Mon Sep 17 00:00:00 2001
From: Yubi Lee <eubnara@gmail.com>
Date: Thu, 5 Sep 2024 20:59:46 +0900
Subject: [PATCH] HBASE-28816: The description of "hbase.superuser" is
 confusing

---
 hbase-common/src/main/resources/hbase-default.xml | 3 ++-
 src/main/asciidoc/_chapters/hbase-default.adoc    | 1 +
 src/main/asciidoc/_chapters/security.adoc         | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hbase-common/src/main/resources/hbase-default.xml b/hbase-common/src/main/resources/hbase-default.xml
index 1bf63b136e04..2c036ae890bc 100644
--- a/hbase-common/src/main/resources/hbase-default.xml
+++ b/hbase-common/src/main/resources/hbase-default.xml
@@ -1201,7 +1201,8 @@ possible configurations would overwhelm and obscure the important.
     <value></value>
     <description>List of users or groups (comma-separated), who are allowed
     full privileges, regardless of stored ACLs, across the cluster.
-    Only used when HBase security is enabled.</description>
+    Only used when HBase security is enabled.
+    Group names should be prefixed with "@".</description>
   </property>
   <property>
     <name>hbase.auth.key.update.interval</name>
diff --git a/src/main/asciidoc/_chapters/hbase-default.adoc b/src/main/asciidoc/_chapters/hbase-default.adoc
index 03391cc38b1a..ccbaaabf694a 100644
--- a/src/main/asciidoc/_chapters/hbase-default.adoc
+++ b/src/main/asciidoc/_chapters/hbase-default.adoc
@@ -1417,6 +1417,7 @@ The policy configuration file used by RPC servers to make
 List of users or groups (comma-separated), who are allowed
     full privileges, regardless of stored ACLs, across the cluster.
     Only used when HBase security is enabled.
+    Group names should be prefixed with "@".
 +
 .Default
 ``
diff --git a/src/main/asciidoc/_chapters/security.adoc b/src/main/asciidoc/_chapters/security.adoc
index b2110a6fbcda..07cbfa7cb948 100644
--- a/src/main/asciidoc/_chapters/security.adoc
+++ b/src/main/asciidoc/_chapters/security.adoc
@@ -2259,7 +2259,7 @@ All options have been discussed separately in the sections above.
 <!-- HBase Superuser -->
 <property>
   <name>hbase.superuser</name>
-  <value>hbase,admin</value>
+  <value>hbase,admin,@superuser-group</value>
 </property>
 <!-- Coprocessors for ACLs and Visibility Tags -->
 <property>