From cdf7c94ded6ea86325d3d92e3a511727edea34ce Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Mon, 23 Dec 2024 16:19:42 +0900 Subject: [PATCH 1/2] HBASE-29040 Fix description of "sampleRate" of PerformanceEvaluation --- .../java/org/apache/hadoop/hbase/PerformanceEvaluation.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java index 1b397546aca6..b2970c77b688 100644 --- a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java +++ b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java @@ -2707,8 +2707,7 @@ protected static void printUsage(final String shortName, final String message) { + "Default: depend on oneCon parameter. if oneCon set to true, then connCount=1, " + "if not, connCount=thread number"); - System.err.println(" sampleRate Execute test on a sample of total " - + "rows. Only supported by randomRead. Default: 1.0"); + System.err.println(" sampleRate Execute test on a sample of total rows. Default: 1.0"); System.err.println(" period Report every 'period' rows: " + "Default: opts.perClientRunRows / 10 = " + DEFAULT_OPTS.getPerClientRunRows() / 10); System.err.println(" cycles How many times to cycle the test. Defaults: 1."); From 989162de44971ed2951340c52a560b82fdf58817 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Mon, 23 Dec 2024 16:30:49 +0900 Subject: [PATCH 2/2] Simplify everyN expression --- .../java/org/apache/hadoop/hbase/PerformanceEvaluation.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java index b2970c77b688..fe58c61dd959 100644 --- a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java +++ b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java @@ -1205,7 +1205,7 @@ private static long nextRandomSeed() { this.opts = options; this.status = status; this.testName = this.getClass().getSimpleName(); - everyN = (int) (opts.totalRows / (opts.totalRows * opts.sampleRate)); + everyN = (int) (1 / opts.sampleRate); if (options.isValueZipf()) { this.zipf = new RandomDistribution.Zipf(this.rand, 1, options.getValueSize(), 1.2); }