From 658ab085324ead38f47d42294e3fabc7672ce119 Mon Sep 17 00:00:00 2001 From: Istvan Toth Date: Wed, 12 Feb 2025 11:42:05 +0100 Subject: [PATCH 1/2] HBASE-29125 Suppress HE_EQUALS_USE_HASHCODE in org.apache.hadoop.hbase.rest.model.ScannerModel$IncludeStartRowFilter --- .../java/org/apache/hadoop/hbase/rest/model/ScannerModel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java index a050dc9e54f9..676c7683afc0 100644 --- a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java +++ b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java @@ -146,7 +146,7 @@ public void setIncludeStartRow(boolean includeStartRow) { } @edu.umd.cs.findbugs.annotations.SuppressWarnings( - value = { "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", "HE_EQUALS_NO_HASHCODE" }, + value = { "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", "HE_EQUALS_NO_HASHCODE", "HE_EQUALS_USE_HASHCODE" }, justification = "1.The supplied value from the JSON Value Filter is of Type Boolean, hence supressing the check, 2.hashCode method will not be invoked, hence supressing the check") private static class IncludeStartRowFilter { @Override From 4e83bcf419880e0b8cb129fc6a56e576f35458f4 Mon Sep 17 00:00:00 2001 From: Istvan Toth Date: Wed, 12 Feb 2025 12:48:24 +0100 Subject: [PATCH 2/2] spotless --- .../java/org/apache/hadoop/hbase/rest/model/ScannerModel.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java index 676c7683afc0..8a01d88422f4 100644 --- a/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java +++ b/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java @@ -146,7 +146,8 @@ public void setIncludeStartRow(boolean includeStartRow) { } @edu.umd.cs.findbugs.annotations.SuppressWarnings( - value = { "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", "HE_EQUALS_NO_HASHCODE", "HE_EQUALS_USE_HASHCODE" }, + value = { "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS", "HE_EQUALS_NO_HASHCODE", + "HE_EQUALS_USE_HASHCODE" }, justification = "1.The supplied value from the JSON Value Filter is of Type Boolean, hence supressing the check, 2.hashCode method will not be invoked, hence supressing the check") private static class IncludeStartRowFilter { @Override