From 5cc3f85f896b0961831ffb588d88fc408a649b64 Mon Sep 17 00:00:00 2001 From: xiuzhu9527 <1406823834@qq.com> Date: Fri, 14 Oct 2022 13:31:51 +0800 Subject: [PATCH] HIVE-26631: Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 7 ------- .../hive/service/cli/thrift/ThriftBinaryCLIService.java | 4 ---- 2 files changed, 11 deletions(-) diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java index 0f8d4f7e791f..4be2f46a06d9 100644 --- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java +++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java @@ -4095,13 +4095,6 @@ public static enum ConfVars { "Minimum number of Thrift worker threads"), HIVE_SERVER2_THRIFT_MAX_WORKER_THREADS("hive.server2.thrift.max.worker.threads", 500, "Maximum number of Thrift worker threads"), - HIVE_SERVER2_THRIFT_LOGIN_BEBACKOFF_SLOT_LENGTH( - "hive.server2.thrift.exponential.backoff.slot.length", "100ms", - new TimeValidator(TimeUnit.MILLISECONDS), - "Binary exponential backoff slot time for Thrift clients during login to HiveServer2,\n" + - "for retries until hitting Thrift client timeout"), - HIVE_SERVER2_THRIFT_LOGIN_TIMEOUT("hive.server2.thrift.login.timeout", "20s", - new TimeValidator(TimeUnit.SECONDS), "Timeout for Thrift clients during login to HiveServer2"), HIVE_SERVER2_THRIFT_WORKER_KEEPALIVE_TIME("hive.server2.thrift.worker.keepalive.time", "60s", new TimeValidator(TimeUnit.SECONDS), "Keepalive time (in seconds) for an idle worker thread. When the number of workers exceeds min workers, " + diff --git a/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java index a97eda8b380b..d7bb36a645f3 100644 --- a/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java +++ b/service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java @@ -102,10 +102,6 @@ protected void initServer() { // Server args int maxMessageSize = hiveConf.getIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_MAX_MESSAGE_SIZE); - int requestTimeout = (int) hiveConf.getTimeVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_LOGIN_TIMEOUT, - TimeUnit.SECONDS); - int beBackoffSlotLength = (int) hiveConf - .getTimeVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_LOGIN_BEBACKOFF_SLOT_LENGTH, TimeUnit.MILLISECONDS); TThreadPoolServer.Args sargs = new TThreadPoolServer.Args(serverSocket).processorFactory(processorFactory) .transportFactory(transportFactory).protocolFactory(new TBinaryProtocol.Factory()) .inputProtocolFactory(new TBinaryProtocol.Factory(true, true, maxMessageSize, maxMessageSize))