From 15bd8c389842379083edfe11827f802ad175fcb5 Mon Sep 17 00:00:00 2001 From: Jonathan Vexler <=> Date: Mon, 31 Oct 2022 13:13:38 -0400 Subject: [PATCH 1/2] call close on spark rdd write client --- .../src/main/java/org/apache/hudi/utilities/HoodieCleaner.java | 1 + 1 file changed, 1 insertion(+) diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java index 39d16e2f11b7f..ae57ecb352ff6 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java @@ -67,6 +67,7 @@ public void run() { HoodieWriteConfig hoodieCfg = getHoodieClientConfig(); SparkRDDWriteClient client = new SparkRDDWriteClient<>(new HoodieSparkEngineContext(jssc), hoodieCfg); client.clean(); + client.close(); } private HoodieWriteConfig getHoodieClientConfig() { From e69e44de825f93e90c245e36311a576fd427b374 Mon Sep 17 00:00:00 2001 From: Jonathan Vexler <=> Date: Tue, 1 Nov 2022 13:40:35 -0400 Subject: [PATCH 2/2] use try with resource instead of close --- .../main/java/org/apache/hudi/utilities/HoodieCleaner.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java index ae57ecb352ff6..9b8bc3abbd19b 100644 --- a/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java +++ b/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java @@ -65,9 +65,9 @@ public HoodieCleaner(Config cfg, JavaSparkContext jssc) { public void run() { HoodieWriteConfig hoodieCfg = getHoodieClientConfig(); - SparkRDDWriteClient client = new SparkRDDWriteClient<>(new HoodieSparkEngineContext(jssc), hoodieCfg); - client.clean(); - client.close(); + try (SparkRDDWriteClient client = new SparkRDDWriteClient<>(new HoodieSparkEngineContext(jssc), hoodieCfg)) { + client.clean(); + } } private HoodieWriteConfig getHoodieClientConfig() {