From bd856c03d16943621abfe58c04ce1847969b7f71 Mon Sep 17 00:00:00 2001 From: Sagar Rao Date: Mon, 14 Nov 2022 07:05:42 +0530 Subject: [PATCH 1/2] Adding try-with-resources block around PredictionTraverser --- .../baidu/hugegraph/api/traversers/AdamicAdarAPI.java | 9 +++++---- .../api/traversers/ResourceAllocationAPI.java | 11 ++++++----- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java index 2f3dc115e7..7fdec68e4f 100644 --- a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java +++ b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java @@ -80,9 +80,10 @@ public String get(@Context GraphManager manager, Directions dir = Directions.convert(EdgeAPI.parseDirection(direction)); HugeGraph g = graph(manager, graph); - PredictionTraverser traverser = new PredictionTraverser(g); - double score = traverser.adamicAdar(sourceId, targetId, dir, - edgeLabel, maxDegree, limit); - return JsonUtil.toJson(ImmutableMap.of("adamic_adar", score)); + try (PredictionTraverser traverser = new PredictionTraverser(g)) { + double score = traverser.adamicAdar(sourceId, targetId, dir, + edgeLabel, maxDegree, limit); + return JsonUtil.toJson(ImmutableMap.of("adamic_adar", score)); + } } } diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java index ed729ad1c5..0333ee09a9 100644 --- a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java +++ b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java @@ -80,10 +80,11 @@ public String create(@Context GraphManager manager, Directions dir = Directions.convert(EdgeAPI.parseDirection(direction)); HugeGraph g = graph(manager, graph); - PredictionTraverser traverser = new PredictionTraverser(g); - double score = traverser.resourceAllocation(sourceId, targetId, dir, - edgeLabel, maxDegree, - limit); - return JsonUtil.toJson(ImmutableMap.of("resource_allocation", score)); + try(PredictionTraverser traverser = new PredictionTraverser(g)) { + double score = traverser.resourceAllocation(sourceId, targetId, dir, + edgeLabel, maxDegree, + limit); + return JsonUtil.toJson(ImmutableMap.of("resource_allocation", score)); + } } } From 895f249158cc588cf8f711ed25d2ebabcb1a9a9e Mon Sep 17 00:00:00 2001 From: Sagar Rao Date: Mon, 14 Nov 2022 18:59:38 +0530 Subject: [PATCH 2/2] Fixing checystyle issues --- .../com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java | 2 +- .../hugegraph/api/traversers/ResourceAllocationAPI.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java index 7fdec68e4f..efd74cab23 100644 --- a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java +++ b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/AdamicAdarAPI.java @@ -82,7 +82,7 @@ public String get(@Context GraphManager manager, HugeGraph g = graph(manager, graph); try (PredictionTraverser traverser = new PredictionTraverser(g)) { double score = traverser.adamicAdar(sourceId, targetId, dir, - edgeLabel, maxDegree, limit); + edgeLabel, maxDegree, limit); return JsonUtil.toJson(ImmutableMap.of("adamic_adar", score)); } } diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java index 0333ee09a9..1705c2c84d 100644 --- a/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java +++ b/hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ResourceAllocationAPI.java @@ -80,10 +80,10 @@ public String create(@Context GraphManager manager, Directions dir = Directions.convert(EdgeAPI.parseDirection(direction)); HugeGraph g = graph(manager, graph); - try(PredictionTraverser traverser = new PredictionTraverser(g)) { + try (PredictionTraverser traverser = new PredictionTraverser(g)) { double score = traverser.resourceAllocation(sourceId, targetId, dir, - edgeLabel, maxDegree, - limit); + edgeLabel, maxDegree, + limit); return JsonUtil.toJson(ImmutableMap.of("resource_allocation", score)); } }