From d41e0ec8637f2e6a709704601463b59fc9e23b51 Mon Sep 17 00:00:00 2001 From: Cayson Yim Date: Tue, 28 May 2024 10:29:00 -0700 Subject: [PATCH 1/3] added tests for display tags --- .../test/java/kafka/test/ClusterConfigTest.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/core/src/test/java/kafka/test/ClusterConfigTest.java b/core/src/test/java/kafka/test/ClusterConfigTest.java index 228c01cf02566..3ad11ff15e255 100644 --- a/core/src/test/java/kafka/test/ClusterConfigTest.java +++ b/core/src/test/java/kafka/test/ClusterConfigTest.java @@ -29,6 +29,9 @@ import java.lang.reflect.Field; import java.util.Arrays; import java.util.Collections; +import java.util.List; +import java.util.Set; +import java.util.LinkedHashSet; import java.util.Map; import java.util.stream.Collectors; @@ -96,4 +99,16 @@ public void testDisksPerBrokerIsZero() { .setDisksPerBroker(0) .build()); } + + @Test + public void testDisplayTags() { + List tags = Collections.singletonList("example tag"); + ClusterConfig clusterConfig = ClusterConfig.defaultBuilder().setTags(tags).build(); + + Set expectedDisplayTags = new LinkedHashSet<>(tags); + expectedDisplayTags.add("MetadataVersion=" + MetadataVersion.latestTesting()); + expectedDisplayTags.add("Security=" + SecurityProtocol.PLAINTEXT); + + Assertions.assertEquals(expectedDisplayTags, clusterConfig.displayTags()); + } } From 21528c94f32ae770cb5b84f218524f452c211a73 Mon Sep 17 00:00:00 2001 From: Cayson Yim Date: Tue, 4 Jun 2024 03:50:14 -0700 Subject: [PATCH 2/3] addressed comments --- core/src/test/java/kafka/test/ClusterConfigTest.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core/src/test/java/kafka/test/ClusterConfigTest.java b/core/src/test/java/kafka/test/ClusterConfigTest.java index 3ad11ff15e255..dd0812c1b20ce 100644 --- a/core/src/test/java/kafka/test/ClusterConfigTest.java +++ b/core/src/test/java/kafka/test/ClusterConfigTest.java @@ -31,7 +31,6 @@ import java.util.Collections; import java.util.List; import java.util.Set; -import java.util.LinkedHashSet; import java.util.Map; import java.util.stream.Collectors; @@ -102,13 +101,13 @@ public void testDisksPerBrokerIsZero() { @Test public void testDisplayTags() { - List tags = Collections.singletonList("example tag"); + List tags = Collections.singletonList("tag"); ClusterConfig clusterConfig = ClusterConfig.defaultBuilder().setTags(tags).build(); - Set expectedDisplayTags = new LinkedHashSet<>(tags); - expectedDisplayTags.add("MetadataVersion=" + MetadataVersion.latestTesting()); - expectedDisplayTags.add("Security=" + SecurityProtocol.PLAINTEXT); + Set expectedDisplayTags = clusterConfig.displayTags(); - Assertions.assertEquals(expectedDisplayTags, clusterConfig.displayTags()); + Assertions.assertTrue(expectedDisplayTags.contains("tag")); + Assertions.assertTrue(expectedDisplayTags.contains("MetadataVersion=" + MetadataVersion.latestTesting())); + Assertions.assertTrue(expectedDisplayTags.contains("Security=" + SecurityProtocol.PLAINTEXT)); } } From d1187ec85468814827126c7b0a0ce051c62b416f Mon Sep 17 00:00:00 2001 From: Cayson Yim Date: Wed, 5 Jun 2024 10:58:26 -0700 Subject: [PATCH 3/3] addressed multi tags --- core/src/test/java/kafka/test/ClusterConfigTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/test/java/kafka/test/ClusterConfigTest.java b/core/src/test/java/kafka/test/ClusterConfigTest.java index dd0812c1b20ce..9d5ac4957b7f1 100644 --- a/core/src/test/java/kafka/test/ClusterConfigTest.java +++ b/core/src/test/java/kafka/test/ClusterConfigTest.java @@ -101,12 +101,14 @@ public void testDisksPerBrokerIsZero() { @Test public void testDisplayTags() { - List tags = Collections.singletonList("tag"); + List tags = Arrays.asList("tag 1", "tag 2", "tag 3"); ClusterConfig clusterConfig = ClusterConfig.defaultBuilder().setTags(tags).build(); Set expectedDisplayTags = clusterConfig.displayTags(); - Assertions.assertTrue(expectedDisplayTags.contains("tag")); + Assertions.assertTrue(expectedDisplayTags.contains("tag 1")); + Assertions.assertTrue(expectedDisplayTags.contains("tag 2")); + Assertions.assertTrue(expectedDisplayTags.contains("tag 3")); Assertions.assertTrue(expectedDisplayTags.contains("MetadataVersion=" + MetadataVersion.latestTesting())); Assertions.assertTrue(expectedDisplayTags.contains("Security=" + SecurityProtocol.PLAINTEXT)); }