diff --git a/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java b/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java index 247bab18d5565..72038b4564cd3 100644 --- a/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java +++ b/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java @@ -45,7 +45,7 @@ */ public class AbstractConfig { - private final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(AbstractConfig.class); /** * Configs for which values have been requested, used to detect unused configs. diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java b/clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java index c7c882496bf8e..5cb1da4f65376 100644 --- a/clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java +++ b/clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java @@ -33,7 +33,7 @@ */ public class Percentiles extends SampledStat implements CompoundStat { - private final Logger log = LoggerFactory.getLogger(Percentiles.class); + private static final Logger log = LoggerFactory.getLogger(Percentiles.class); public enum BucketSizing { CONSTANT, LINEAR diff --git a/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java b/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java index daae977d72729..2241eb50fdc07 100644 --- a/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java +++ b/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java @@ -99,7 +99,7 @@ * broker configuration property. */ public class OAuthBearerUnsecuredLoginCallbackHandler implements AuthenticateCallbackHandler { - private final Logger log = LoggerFactory.getLogger(OAuthBearerUnsecuredLoginCallbackHandler.class); + private static final Logger log = LoggerFactory.getLogger(OAuthBearerUnsecuredLoginCallbackHandler.class); private static final String OPTION_PREFIX = "unsecuredLogin"; private static final String PRINCIPAL_CLAIM_NAME_OPTION = OPTION_PREFIX + "PrincipalClaimName"; private static final String LIFETIME_SECONDS_OPTION = OPTION_PREFIX + "LifetimeSeconds"; diff --git a/clients/src/main/java/org/apache/kafka/common/utils/KafkaThread.java b/clients/src/main/java/org/apache/kafka/common/utils/KafkaThread.java index 2f5e15f46349e..a2ea3dc88b663 100644 --- a/clients/src/main/java/org/apache/kafka/common/utils/KafkaThread.java +++ b/clients/src/main/java/org/apache/kafka/common/utils/KafkaThread.java @@ -24,7 +24,7 @@ */ public class KafkaThread extends Thread { - private final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(KafkaThread.class); public static KafkaThread daemon(final String name, Runnable runnable) { return new KafkaThread(name, runnable, true); diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTaskContext.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTaskContext.java index 3baf4772b5bda..e767c7640b47a 100644 --- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTaskContext.java +++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTaskContext.java @@ -35,7 +35,7 @@ public class WorkerSinkTaskContext implements SinkTaskContext { - private final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(WorkerSinkTaskContext.class); private final Map offsets; private final Consumer consumer; private final WorkerSinkTask sinkTask; diff --git a/metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java b/metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java index ec733b3ca196f..52a5792ced1f3 100644 --- a/metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java +++ b/metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java @@ -163,7 +163,7 @@ public String toString() { } public static class SharedLogData { - private final Logger log = LoggerFactory.getLogger(SharedLogData.class); + private static final Logger log = LoggerFactory.getLogger(SharedLogData.class); /** * Maps node IDs to the matching log managers. diff --git a/server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java b/server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java index 1dbebdfdecc4d..64c8f8441b97c 100644 --- a/server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java +++ b/server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java @@ -54,7 +54,7 @@ public Pattern getPattern() { } public static class IncludeList extends TopicFilter { - private final Logger log = LoggerFactory.getLogger(IncludeList.class); + private static final Logger log = LoggerFactory.getLogger(IncludeList.class); public IncludeList(String rawRegex) { super(rawRegex); } diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java index 6b5a1753c8bf9..4a288bb0e83f6 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java @@ -43,7 +43,7 @@ public class KStreamSlidingWindowAggregate implements KStreamAggProcessorSupplier, VAgg> { - private final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(KStreamSlidingWindowAggregate.class); private final String storeName; private final SlidingWindows windows; diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java index 44169cf0eb2da..340ce82d85670 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java @@ -41,7 +41,7 @@ public class KStreamWindowAggregate implements KStreamAggProcessorSupplier, VAgg> { - private final Logger log = LoggerFactory.getLogger(getClass()); + private static final Logger log = LoggerFactory.getLogger(KStreamWindowAggregate.class); private final String storeName; private final Windows windows; diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java index 003298cc870d4..97b686eaff632 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java @@ -30,7 +30,7 @@ public class StreamSourceNode extends SourceGraphNode { - private final Logger log = LoggerFactory.getLogger(StreamSourceNode.class); + private static final Logger log = LoggerFactory.getLogger(StreamSourceNode.class); public StreamSourceNode(final String nodeName, final Collection topicNames, diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java index eabf9e3d5c471..3f117088fbded 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java @@ -45,7 +45,7 @@ public class ProcessorNode { - private final Logger log = LoggerFactory.getLogger(ProcessorNode.class); + private static final Logger log = LoggerFactory.getLogger(ProcessorNode.class); private final List> children; private final Map> childByName; diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java index b65bba4e16edf..b0fc1f6851188 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java @@ -31,7 +31,7 @@ import java.util.Set; public class ProcessorTopology { - private final Logger log = LoggerFactory.getLogger(ProcessorTopology.class); + private static final Logger log = LoggerFactory.getLogger(ProcessorTopology.class); private final List> processorNodes; private final Map> sourceNodesByName; diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java index 10f75f2bd06ad..d57d5318c680c 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowStoreBuilder.java @@ -29,7 +29,7 @@ import java.util.Objects; public class WindowStoreBuilder extends AbstractStoreBuilder> { - private final Logger log = LoggerFactory.getLogger(WindowStoreBuilder.class); + private static final Logger log = LoggerFactory.getLogger(WindowStoreBuilder.class); private final WindowBytesStoreSupplier storeSupplier; diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionOptimizingTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionOptimizingTest.java index cac44dbb5e94c..91b95b87a7fee 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionOptimizingTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionOptimizingTest.java @@ -72,7 +72,7 @@ @SuppressWarnings("deprecation") public class RepartitionOptimizingTest { - private final Logger log = LoggerFactory.getLogger(RepartitionOptimizingTest.class); + private static final Logger log = LoggerFactory.getLogger(RepartitionOptimizingTest.class); private static final String INPUT_TOPIC = "input"; private static final String COUNT_TOPIC = "outputTopic_0"; diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionWithMergeOptimizingTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionWithMergeOptimizingTest.java index f6a12d6477b8e..a9287fc3e5993 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionWithMergeOptimizingTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionWithMergeOptimizingTest.java @@ -60,7 +60,7 @@ public class RepartitionWithMergeOptimizingTest { - private final Logger log = LoggerFactory.getLogger(RepartitionWithMergeOptimizingTest.class); + private static final Logger log = LoggerFactory.getLogger(RepartitionWithMergeOptimizingTest.class); private static final String INPUT_A_TOPIC = "inputA"; private static final String INPUT_B_TOPIC = "inputB"; diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java index d61c530c92ed1..b195600c3925e 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java @@ -82,7 +82,7 @@ public class StreamsAssignmentScaleTest { static final long MAX_ASSIGNMENT_DURATION = 120 * 1000L; // we should stay below `max.poll.interval.ms` static final String APPLICATION_ID = "streams-assignment-scale-test"; - private final Logger log = LoggerFactory.getLogger(StreamsAssignmentScaleTest.class); + private static final Logger log = LoggerFactory.getLogger(StreamsAssignmentScaleTest.class); /* HighAvailabilityTaskAssignor tests */ diff --git a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java index 6e216dcdbca8f..64cf3c7eb0b51 100644 --- a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java @@ -154,7 +154,7 @@ public Consumer getConsumer(final Map config) { public static class FutureStreamsPartitionAssignor extends StreamsPartitionAssignor { private static final Map CLIENT_TAGS = mkMap(mkEntry("t1", "v1"), mkEntry("t2", "v2")); - private final Logger log = LoggerFactory.getLogger(FutureStreamsPartitionAssignor.class); + private static final Logger log = LoggerFactory.getLogger(FutureStreamsPartitionAssignor.class); private AtomicInteger usedSubscriptionMetadataVersionPeek; private AtomicLong nextScheduledRebalanceMs; diff --git a/trogdor/src/main/java/org/apache/kafka/trogdor/workload/TimestampRecordProcessor.java b/trogdor/src/main/java/org/apache/kafka/trogdor/workload/TimestampRecordProcessor.java index 529e228c38c4d..19d1d32d174d0 100644 --- a/trogdor/src/main/java/org/apache/kafka/trogdor/workload/TimestampRecordProcessor.java +++ b/trogdor/src/main/java/org/apache/kafka/trogdor/workload/TimestampRecordProcessor.java @@ -55,7 +55,7 @@ public class TimestampRecordProcessor implements RecordProcessor { private final ByteBuffer buffer; private final Histogram histogram; - private final Logger log = LoggerFactory.getLogger(TimestampRecordProcessor.class); + private static final Logger log = LoggerFactory.getLogger(TimestampRecordProcessor.class); static final float[] PERCENTILES = {0.5f, 0.95f, 0.99f};