From 6d1aa546f0f05bd4a9fbd619fa6cbad80d45160b Mon Sep 17 00:00:00 2001 From: Andrew Schofield Date: Thu, 24 Apr 2025 08:45:54 +0100 Subject: [PATCH] MINOR: Change KIP-932 log messages from early access to preview --- .../consumer/internals/ShareConsumerDelegateCreator.java | 4 ++-- core/src/main/scala/kafka/server/KafkaConfig.scala | 4 ---- .../kafka/coordinator/group/GroupCoordinatorConfig.java | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerDelegateCreator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerDelegateCreator.java index 625f6abf0cd38..9eb5fd13699b0 100644 --- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerDelegateCreator.java +++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerDelegateCreator.java @@ -45,7 +45,7 @@ public ShareConsumerDelegate create(final ConsumerConfig config, try { LogContext logContext = new LogContext(); Logger log = logContext.logger(getClass()); - log.warn("Share groups and KafkaShareConsumer are part of the early access of KIP-932 and MUST NOT be used in production."); + log.warn("Share groups and KafkaShareConsumer are part of a preview feature introduced by KIP-932, and are not recommended for use in production."); return new ShareConsumerImpl<>(config, keyDeserializer, valueDeserializer); } catch (KafkaException e) { throw e; @@ -66,7 +66,7 @@ public ShareConsumerDelegate create(final LogContext logContext, final ConsumerMetadata metadata) { try { Logger log = logContext.logger(getClass()); - log.warn("Share groups and KafkaShareConsumer are part of the early access of KIP-932 and MUST NOT be used in production."); + log.warn("Share groups and KafkaShareConsumer are part of a preview feature introduced by KIP-932, and are not recommended for use in production."); return new ShareConsumerImpl<>( logContext, clientId, diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala index 7049d5f24744b..b982e72e141fa 100755 --- a/core/src/main/scala/kafka/server/KafkaConfig.scala +++ b/core/src/main/scala/kafka/server/KafkaConfig.scala @@ -379,10 +379,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (!protocols.contains(GroupType.CLASSIC)) { throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}' protocol is not supported.") } - if (protocols.contains(GroupType.SHARE)) { - warn(s"Share groups and the new '${GroupType.SHARE}' rebalance protocol are enabled. " + - "This is part of the early access of KIP-932 and MUST NOT be used in production.") - } if (protocols.contains(GroupType.STREAMS)) { warn(s"Streams groups and the new '${GroupType.STREAMS}' rebalance protocol are enabled. " + "This is part of the early access of KIP-1071 and MUST NOT be used in production.") diff --git a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java index ece60a36dbaf9..1221f937e8a07 100644 --- a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java +++ b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java @@ -60,7 +60,7 @@ public class GroupCoordinatorConfig { /// public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG = "group.coordinator.rebalance.protocols"; public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC = "The list of enabled rebalance protocols." + - "The " + Group.GroupType.SHARE + " and " + Group.GroupType.STREAMS + " rebalance protocols are in early access and therefore must not be used in production."; + "The " + Group.GroupType.STREAMS + " rebalance protocol is in early access and therefore must not be used in production."; public static final List GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT = List.of( Group.GroupType.CLASSIC.toString(), Group.GroupType.CONSUMER.toString());