-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19865: Document queues metrics changes in ops.html #21046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
| this.delayedShareFetchExpiresPerSec = new MetricNameTemplate("ExpiresPerSec", delayedShareFetchMetricsName, | ||
| "The expired delayed share fetch operation rate per second.", tags); | ||
|
|
||
| /* DelayedOperationPurgatory metrics */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure if we need to show the DelayedOperationPurgatory metrics in the documentation, as it doesn't only apply to share group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention this. I do only see that following is defined in Kafka documentation kafka.server:type=DelayedRemoteFetchMetrics,name=ExpiresPerSec,topic=([-.\w]+) and not for others. Also I see kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation has been declared separately for Produce and Fetch then we should follow the similar pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. It's updated.
|
Hi @apoorvmittal10 @AndrewJSchofield, gentle ping on this. Please take a look when you get a chance. Thanks! |
|
Thanks for the PR @JimmyWang6.
|
|
In the PR we have just |
I agree. It looks a bit odd with the different types of metrics mixed up together. |
|
@JimmyWang6 Can we please update the description to how documentation looks now after the changes? |
|
Updated the document and description based on the feedback, thanks:) |

From
KAFKA-19865,
This PR introduces documentation support for monitoring Kafka share
groups and share consumers, including new metric registries and
documentation updates. The changes add new classes to define and expose
share group metrics, and update the documentation to describe these
metrics and how to monitor them.
Pre-view:
