KAFKA-19969: Add Per-Topic Observability Metrics for Remote Fetch Quota Enforcement #21090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta Enforcement Remote fetch quota enforcement lacks per-topic visibility, making it difficult to identify which topics consume the most quota or experience throttling. Add 4 new per-topic metrics: - RemoteFetchQuotaBytesPerSec: quota bytes consumed per topic - RemoteFetchQuotaThrottledPerSec: throttled requests per topic - RemoteFetchQuotaThrottleTimeMs: throttle time distribution - RemoteFetchSizeBytes: fetch size distribution
github-actions
bot
added
triage
| return QuotaUtils.throttleTime(qve, time.milliseconds()); | ||
|
|
||
| // Record throttling metrics if topic provided | ||
| if (brokerTopicStats != null && topic != null) { |
There was a problem hiding this comment.
IMO more defense could be added here, in case this additional code leads to exception (today or in future) the throrrleTime will never be returned to caller. Worth adding another try catch to ensure this is safe and in worst case returns ? QuotaUtils.throttleTime(qve, time.milliseconds());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote fetch quota enforcement lacks per-topic visibility, making it difficult to identify which topics consume the most quota or experience throttling.
Add 4 new per-topic metrics: