From cfa89996c1f220f96dd469a5dd24dc208999f09f Mon Sep 17 00:00:00 2001
From: David Mollitor <dmollitor@apache.org>
Date: Sun, 12 Jan 2020 11:42:46 -0500
Subject: [PATCH] KAFKA-9407: Return Immutable List from SchemaSourceTask

---
 .../org/apache/kafka/connect/tools/SchemaSourceTask.java    | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceTask.java b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceTask.java
index 95b49af6155c7..6fde784e7861b 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceTask.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceTask.java
@@ -26,7 +26,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -154,13 +153,12 @@ public List<SourceRecord> poll() throws InterruptedException {
             }
 
             System.out.println("{\"task\": " + id + ", \"seqno\": " + seqno + "}");
-            List<SourceRecord> result = Collections.singletonList(srcRecord);
             seqno++;
             count++;
-            return result;
+            return Collections.singletonList(srcRecord);
         } else {
             throttler.throttle();
-            return new ArrayList<>();
+            return Collections.emptyList();
         }
     }