From 3754edb403db9427ea8e991516b97d54a98ccad9 Mon Sep 17 00:00:00 2001 From: jyf111 Date: Sun, 5 Nov 2023 21:46:03 +0800 Subject: [PATCH 1/2] Add more sanity checks for docker image --- .github/workflows/kvrocks.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/kvrocks.yaml b/.github/workflows/kvrocks.yaml index 58dcefe492b..92a57bee022 100644 --- a/.github/workflows/kvrocks.yaml +++ b/.github/workflows/kvrocks.yaml @@ -310,7 +310,18 @@ jobs: tags: kvrocks:ci outputs: type=docker - name: Test built image - run: docker run --rm kvrocks:ci -v + run: | + ID="$(docker run --rm -d -p 6666:6666 kvrocks:ci)" + sleep 1m + if [ "$(docker inspect --format='{{.State.Health.Status}}' $ID)" != "healthy" ]; then + echo "The container is not healthy." + exit 1 + fi + if [ "$(ss --listening --no-header --tcp '( sport = :6666 )')" == "" ]; then + echo "The container listening port can not be accessed from outside." + exit 1 + fi + docker stop $ID build-and-test-in-container: name: Build and test in container From 81f88aaf4b01f17df14a7852b695b548e0d4fbf4 Mon Sep 17 00:00:00 2001 From: jyf111 Date: Tue, 7 Nov 2023 09:19:23 +0800 Subject: [PATCH 2/2] Restore the version check --- .github/workflows/kvrocks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/kvrocks.yaml b/.github/workflows/kvrocks.yaml index 92a57bee022..25e47cf38bb 100644 --- a/.github/workflows/kvrocks.yaml +++ b/.github/workflows/kvrocks.yaml @@ -311,6 +311,7 @@ jobs: outputs: type=docker - name: Test built image run: | + docker run --rm kvrocks:ci -v ID="$(docker run --rm -d -p 6666:6666 kvrocks:ci)" sleep 1m if [ "$(docker inspect --format='{{.State.Health.Status}}' $ID)" != "healthy" ]; then