diff --git a/src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDepMgt.java b/src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDepMgt.java index 268ac1d13..d3392a2d7 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDepMgt.java +++ b/src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDepMgt.java @@ -34,6 +34,8 @@ import org.apache.maven.model.Dependency; import org.apache.maven.model.DependencyManagement; import org.apache.maven.model.Exclusion; +import org.apache.maven.plugin.MojoExecutionException; +import org.apache.maven.plugin.MojoFailureException; import org.apache.maven.plugins.dependency.testUtils.DependencyArtifactStubFactory; import org.apache.maven.plugins.dependency.testUtils.stubs.DependencyProjectStub; import org.apache.maven.project.MavenProject; @@ -192,60 +194,30 @@ public void testGetMismatch() } public void testMojo() - throws IOException + throws IOException, MojoExecutionException, MojoFailureException { mojo.setIgnoreDirect( false ); - try - { - // test with nothing in depMgt - mojo.execute(); - } - catch ( Exception e ) - { - e.printStackTrace(); - fail( "Caught Unexpected Exception:" + e.getLocalizedMessage() ); - } + // test with nothing in depMgt + mojo.execute(); - try - { - DependencyProjectStub project = (DependencyProjectStub) mojo.getProject(); - project.setDependencyManagement( depMgt ); - // test with exclusion - mojo.execute(); - } - catch ( Exception e ) - { - e.printStackTrace(); - fail( "Caught Unexpected Exception:" + e.getLocalizedMessage() ); - } + DependencyProjectStub project = (DependencyProjectStub) mojo.getProject(); + project.setDependencyManagement( depMgt ); + // test with exclusion + mojo.execute(); try { - DependencyProjectStub project = (DependencyProjectStub) mojo.getProject(); - project.setDependencyManagement( depMgt ); // test with exclusion mojo.setFailBuild( true ); mojo.execute(); fail( "Expected exception to fail the build." ); } - catch ( Exception e ) + catch ( MojoExecutionException e ) { - System.out.println( "Caught Expected Exception:" + e.getLocalizedMessage() ); } - try - { - DependencyProjectStub project = (DependencyProjectStub) mojo.getProject(); - project.setDependencyManagement( depMgt ); - // test with exclusion - mojo.setFailBuild( true ); - mojo.setIgnoreDirect( true ); - mojo.execute(); - } - catch ( Exception e ) - { - e.printStackTrace(); - fail( "Caught Unexpected Exception:" + e.getLocalizedMessage() ); - } + mojo.setFailBuild( true ); + mojo.setIgnoreDirect( true ); + mojo.execute(); } } diff --git a/src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java b/src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java index ee6687560..9a23afd55 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java +++ b/src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java @@ -34,6 +34,7 @@ import java.util.Set; import static java.util.Collections.singletonList; + import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; diff --git a/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java b/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java index a0954ee81..f8127150b 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java +++ b/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java @@ -96,10 +96,6 @@ public class DependencyProjectStub private List pluginArtifactRepositories; - // private ArtifactRepository releaseArtifactRepository; - - // private ArtifactRepository snapshotArtifactRepository; - private List activeProfiles; private Set dependencyArtifacts; @@ -615,6 +611,7 @@ public Scm getScm() return null; } + @Override public void setMailingLists( List list ) { @@ -630,6 +627,7 @@ public void addMailingList( MailingList mailingList ) } + @Override public void setDevelopers( List list ) { @@ -951,6 +949,7 @@ public List getBuildExtensions() return Collections.emptyList(); } + @Override public Set createArtifacts( ArtifactFactory artifactFactory, String string, ArtifactFilter artifactFilter ) throws InvalidDependencyVersionException { diff --git a/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java b/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java index 5c202a651..5e7769885 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java +++ b/src/test/java/org/apache/maven/plugins/dependency/utils/translators/TestClassifierTypeTranslator.java @@ -55,7 +55,6 @@ public class TestClassifierTypeTranslator Log log = new SilentLog(); - private ArtifactHandlerManager artifactHandlerManager; @Override @@ -75,7 +74,6 @@ protected void setUp() DependencyArtifactStubFactory factory = new DependencyArtifactStubFactory( null, false ); artifacts = factory.getMixedArtifacts(); - MavenSession session = newMavenSession( new MavenProjectStub() ); DefaultRepositorySystemSession repoSession = (DefaultRepositorySystemSession) session.getRepositorySession();