From 82c57723c6345bca0f4574c1784a4b443fdeb9b3 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 18 May 2020 14:56:12 -0400 Subject: [PATCH 1/2] don't care about old versions --- .../maven/plugins/dependency/analyze/AnalyzeDepMgt.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java b/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java index b2c0ca91a..b6c1264ed 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java +++ b/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java @@ -41,10 +41,8 @@ /** * This mojo looks at the dependencies after final resolution and looks for mismatches in your dependencyManagement - * section. In versions of maven prior to 2.0.6, it was possible to inherit versions that didn't match your - * dependencyManagement. See MNG-1577 for more info. This - * mojo is also useful for just detecting projects that override the dependencyManagement directly. Set ignoreDirect to - * false to detect these otherwise normal conditions. + * section. This mojo is also useful for detecting projects that override the dependencyManagement directly. + * Set ignoreDirect to false to detect these otherwise normal conditions. * * @author Brian Fox * @since 2.0-alpha-3 From d6b48e4f5e09ada8bb2b4475c6780becaf15f834 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Thu, 21 May 2020 13:06:22 -0400 Subject: [PATCH 2/2] clean up some dead code --- .../stubs/DependencyProjectStub.java | 48 ++----------------- 1 file changed, 3 insertions(+), 45 deletions(-) diff --git a/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java b/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java index f8bafdb79..a0954ee81 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java +++ b/src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyProjectStub.java @@ -108,20 +108,8 @@ public class DependencyProjectStub private Artifact artifact; - // private Map artifactMap; - private Model originalModel; - // private Map pluginArtifactMap; - - // private Map reportArtifactMap; - - // private Map extensionArtifactMap; - - // private Map projectReferences; - - // private Build buildOverlay; - private boolean executionRoot; private List compileArtifacts; @@ -422,36 +410,6 @@ public void setScriptSourceRoots( List scriptSourceRoots ) this.scriptSourceRoots = scriptSourceRoots; } - public void setArtifactMap( Map artifactMap ) - { - // this.artifactMap = artifactMap; - } - - public void setPluginArtifactMap( Map pluginArtifactMap ) - { - // this.pluginArtifactMap = pluginArtifactMap; - } - - public void setReportArtifactMap( Map reportArtifactMap ) - { - // this.reportArtifactMap = reportArtifactMap; - } - - public void setExtensionArtifactMap( Map extensionArtifactMap ) - { - // this.extensionArtifactMap = extensionArtifactMap; - } - - public void setProjectReferences( Map projectReferences ) - { - // this.projectReferences = projectReferences; - } - - public void setBuildOverlay( Build buildOverlay ) - { - // this.buildOverlay = buildOverlay; - } - public void setCompileDependencies( List compileDependencies ) { this.compileDependencies = compileDependencies; @@ -657,7 +615,7 @@ public Scm getScm() return null; } - public void setMailingLists( List list ) + public void setMailingLists( List list ) { } @@ -672,7 +630,7 @@ public void addMailingList( MailingList mailingList ) } - public void setDevelopers( List list ) + public void setDevelopers( List list ) { } @@ -742,7 +700,7 @@ public Reporting getReporting() return null; } - public void setLicenses( List list ) + public void setLicenses( List list ) { }