From 5ec642dced86a11c9ecadfa6216427c9c4b35057 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 21 Jul 2025 07:29:43 -0400 Subject: [PATCH 1/3] Add test for prefixed Maven elements --- .../test/java/org/apache/maven/DefaultMavenTest.java | 10 ++++++++++ .../src/test/projects/default-maven/prefix/pom.xml | 10 ++++++++++ 2 files changed, 20 insertions(+) create mode 100644 impl/maven-core/src/test/projects/default-maven/prefix/pom.xml diff --git a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java index 7c1f8e10205b..2d9ec84001a2 100644 --- a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java +++ b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java @@ -87,6 +87,16 @@ void testThatErrorDuringProjectDependencyGraphCreationAreStored() throws Excepti assertEquals(ProjectCycleException.class, result.getExceptions().get(0).getClass()); } + @Test + void testThatNamespacePrefixAreAllowed() throws Exception { + MavenExecutionRequest request = + createMavenExecutionRequest(getProject("prefix")).setGoals(asList("validate")); + + MavenExecutionResult result = maven.execute(request); + + assertTrue(result.getExceptions().isEmpty()); + } + @Test void testMavenProjectNoDuplicateArtifacts() throws Exception { MavenProjectHelper mavenProjectHelper = getContainer().lookup(MavenProjectHelper.class); diff --git a/impl/maven-core/src/test/projects/default-maven/prefix/pom.xml b/impl/maven-core/src/test/projects/default-maven/prefix/pom.xml new file mode 100644 index 000000000000..de7d1b0a4083 --- /dev/null +++ b/impl/maven-core/src/test/projects/default-maven/prefix/pom.xml @@ -0,0 +1,10 @@ + + 4.0.0 + + prefix + prefix + 1.0-SNAPSHOT + pom + + From 6376d62fcc2fdbc342df8a4ba9d6ab0e4d222ce6 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 21 Jul 2025 07:42:16 -0400 Subject: [PATCH 2/3] spotless --- .../src/test/java/org/apache/maven/DefaultMavenTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java index 2d9ec84001a2..7530e88d5285 100644 --- a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java +++ b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java @@ -90,7 +90,7 @@ void testThatErrorDuringProjectDependencyGraphCreationAreStored() throws Excepti @Test void testThatNamespacePrefixAreAllowed() throws Exception { MavenExecutionRequest request = - createMavenExecutionRequest(getProject("prefix")).setGoals(asList("validate")); + createMavenExecutionRequest(getProject("prefix")).setGoals(asList("validate")); MavenExecutionResult result = maven.execute(request); From 156a6e4eb36be75ec452f5fe20376c7d019c29d1 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 21 Jul 2025 08:22:39 -0400 Subject: [PATCH 3/3] plural --- .../src/test/java/org/apache/maven/DefaultMavenTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java index 7530e88d5285..bbdc02ec92c1 100644 --- a/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java +++ b/impl/maven-core/src/test/java/org/apache/maven/DefaultMavenTest.java @@ -78,7 +78,7 @@ void testEnsureResolverSessionHasMavenWorkspaceReader() throws Exception { } @Test - void testThatErrorDuringProjectDependencyGraphCreationAreStored() throws Exception { + void testThatErrorsDuringProjectDependencyGraphCreationAreStored() throws Exception { MavenExecutionRequest request = createMavenExecutionRequest(getProject("cyclic-reference")).setGoals(asList("validate")); @@ -88,7 +88,7 @@ void testThatErrorDuringProjectDependencyGraphCreationAreStored() throws Excepti } @Test - void testThatNamespacePrefixAreAllowed() throws Exception { + void testThatNamespacePrefixesAreAllowed() throws Exception { MavenExecutionRequest request = createMavenExecutionRequest(getProject("prefix")).setGoals(asList("validate"));