From cceea99248879e9368fe65e6b4c41f3d799a41f8 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Mon, 31 Mar 2025 08:13:14 -0400 Subject: [PATCH] No catch block needed when rethrowing same exception --- .../plugin/DefaultPluginDescriptorCache.java | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/impl/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginDescriptorCache.java b/impl/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginDescriptorCache.java index df5550517bdb..3371047c87b4 100644 --- a/impl/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginDescriptorCache.java +++ b/impl/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginDescriptorCache.java @@ -67,21 +67,17 @@ public PluginDescriptor get(Key cacheKey) { public PluginDescriptor get(Key key, PluginDescriptorSupplier supplier) throws PluginDescriptorParsingException, PluginResolutionException, InvalidPluginDescriptorException { - try { - PluginDescriptor desc = descriptors.get(key); - if (desc == null) { - synchronized (key) { - desc = descriptors.get(key); - if (desc == null) { - desc = supplier.load(); - descriptors.putIfAbsent(key, clone(desc)); - } + PluginDescriptor desc = descriptors.get(key); + if (desc == null) { + synchronized (key) { + desc = descriptors.get(key); + if (desc == null) { + desc = supplier.load(); + descriptors.putIfAbsent(key, clone(desc)); } } - return clone(desc); - } catch (PluginDescriptorParsingException | PluginResolutionException | InvalidPluginDescriptorException e) { - throw e; } + return clone(desc); } public void put(Key cacheKey, PluginDescriptor pluginDescriptor) {