Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Commit 3218ebb

Browse files
author
Joe Evans
committed
Replace deprecated ConstantFill onnx operator with Identity, add commented out models that work with onnx export but fail with onnxruntime.
1 parent 0378538 commit 3218ebb

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

python/mxnet/contrib/onnx/mx2onnx/_op_translations.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -779,10 +779,10 @@ def convert_copy(node, **kwargs):
779779

780780
@mx_op.register("identity")
781781
def convert_identity(node, **kwargs):
782-
"""Map MXNet's identity operator attributes to onnx's ConstantFill operator
782+
"""Map MXNet's identity operator attributes to onnx's Identity operator
783783
and return the created node.
784784
"""
785-
return create_basic_op_node('ConstantFill', node, kwargs)
785+
return create_basic_op_node('Identity', node, kwargs)
786786

787787
@mx_op.register("InstanceNorm")
788788
def convert_instancenorm(node, **kwargs):
@@ -1009,12 +1009,12 @@ def convert_logistic_regression_output(node, **kwargs):
10091009
@mx_op.register("BlockGrad")
10101010
def convert_blockgrad(node, **kwargs):
10111011
""" Skip operator """
1012-
return create_basic_op_node('ConstantFill', node, kwargs)
1012+
return create_basic_op_node('Identity', node, kwargs)
10131013

10141014
@mx_op.register("MakeLoss")
10151015
def convert_makeloss(node, **kwargs):
10161016
""" Skip operator """
1017-
return create_basic_op_node('ConstantFill', node, kwargs)
1017+
return create_basic_op_node('Identity', node, kwargs)
10181018

10191019
@mx_op.register("Concat")
10201020
def convert_concat(node, **kwargs):

tests/python-pytest/onnx/test_onnxruntime.py

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,24 @@ def normalize_image(imgfile):
191191
'center_net_resnet101_v1b_voc',
192192
'center_net_resnet18_v1b_coco',
193193
'center_net_resnet50_v1b_coco',
194-
'center_net_resnet101_v1b_coco'
194+
'center_net_resnet101_v1b_coco',
195+
# the following models are failing due to onnxruntime errors
196+
#'ssd_300_vgg16_atrous_voc',
197+
#'ssd_512_vgg16_atrous_voc',
198+
#'ssd_512_resnet50_v1_voc',
199+
#'ssd_512_mobilenet1.0_voc',
200+
#'faster_rcnn_resnet50_v1b_voc',
201+
#'yolo3_darknet53_voc',
202+
#'yolo3_mobilenet1.0_voc',
203+
#'ssd_300_vgg16_atrous_coco',
204+
#'ssd_512_vgg16_atrous_coco',
205+
#'ssd_300_resnet34_v1b_coco',
206+
#'ssd_512_resnet50_v1_coco',
207+
#'ssd_512_mobilenet1.0_coco',
208+
#'faster_rcnn_resnet50_v1b_coco',
209+
#'faster_rcnn_resnet101_v1d_coco',
210+
#'yolo3_darknet53_coco',
211+
#'yolo3_mobilenet1.0_coco',
195212
])
196213
def test_obj_detection_model_inference_onnxruntime(tmp_path, model):
197214
def normalize_image(imgfile):

0 commit comments

Comments
 (0)