From 3476395765e90649ddcac5aef265fc14113bea14 Mon Sep 17 00:00:00 2001 From: Da Zheng Date: Tue, 13 Mar 2018 20:55:56 +0000 Subject: [PATCH 1/2] enable all activations. --- src/operator/nn/mkldnn/mkldnn_act.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/operator/nn/mkldnn/mkldnn_act.cc b/src/operator/nn/mkldnn/mkldnn_act.cc index 71fdf4ca585b..b8b094d1e78f 100644 --- a/src/operator/nn/mkldnn/mkldnn_act.cc +++ b/src/operator/nn/mkldnn/mkldnn_act.cc @@ -45,11 +45,9 @@ namespace op { bool SupportMKLDNNAct(const ActivationParam& param) { // We only enable ReLU for now. It seems other activations have some precision // problems. - return param.act_type == activation::kReLU; -#if 0 + return param.act_type == activation::kReLU || param.act_type == activation::kSigmoid || param.act_type == activation::kSoftReLU; -#endif } static inline mkldnn::algorithm GetMKLDNNActAlgo(const ActivationParam& param) { From 3bf6d9641fc25244ddec9d06fa04ffc984d5da2d Mon Sep 17 00:00:00 2001 From: Da Zheng Date: Tue, 13 Mar 2018 17:34:35 -0700 Subject: [PATCH 2/2] Update mkldnn_act.cc --- src/operator/nn/mkldnn/mkldnn_act.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/operator/nn/mkldnn/mkldnn_act.cc b/src/operator/nn/mkldnn/mkldnn_act.cc index b8b094d1e78f..8c76932c82d4 100644 --- a/src/operator/nn/mkldnn/mkldnn_act.cc +++ b/src/operator/nn/mkldnn/mkldnn_act.cc @@ -43,8 +43,6 @@ namespace mxnet { namespace op { bool SupportMKLDNNAct(const ActivationParam& param) { - // We only enable ReLU for now. It seems other activations have some precision - // problems. return param.act_type == activation::kReLU || param.act_type == activation::kSigmoid || param.act_type == activation::kSoftReLU;