From b95623ec6d33d72dfb6fcf515653809b001a8815 Mon Sep 17 00:00:00 2001 From: stu1130 Date: Wed, 27 Mar 2019 10:12:34 -0700 Subject: [PATCH 1/3] set success_rate to 0.2 --- tests/python/unittest/test_random.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/python/unittest/test_random.py b/tests/python/unittest/test_random.py index c3eebcf27922..7910a8f83e2b 100644 --- a/tests/python/unittest/test_random.py +++ b/tests/python/unittest/test_random.py @@ -577,12 +577,12 @@ def test_poisson_generator(): buckets = [(-1.0, lam - 0.5), (lam - 0.5, 2 * lam + 0.5), (2 * lam + 0.5, np.inf)] probs = [ss.poisson.cdf(bucket[1], lam) - ss.poisson.cdf(bucket[0], lam) for bucket in buckets] generator_mx = lambda x: mx.nd.random.poisson(lam, shape=x, ctx=ctx, dtype=dtype).asnumpy() - verify_generator(generator=generator_mx, buckets=buckets, probs=probs) + verify_generator(generator=generator_mx, buckets=buckets, probs=probs, success_rate=0.2) generator_mx_same_seed = \ lambda x: np.concatenate( [mx.nd.random.poisson(lam, shape=x // 10, ctx=ctx, dtype=dtype).asnumpy() for _ in range(10)]) - verify_generator(generator=generator_mx_same_seed, buckets=buckets, probs=probs) + verify_generator(generator=generator_mx_same_seed, buckets=buckets, probs=probs, success_rate=0.2) @unittest.skip("Flaky test. Tracked in https://github.com/apache/incubator-mxnet/issues/13506") @with_seed() From 7c4c5e9dac733f47ec606d344fcd8fa67488c1a1 Mon Sep 17 00:00:00 2001 From: stu1130 Date: Wed, 27 Mar 2019 14:08:34 -0700 Subject: [PATCH 2/3] fix the flaky test --- python/mxnet/test_utils.py | 2 +- tests/python/unittest/test_random.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/python/mxnet/test_utils.py b/python/mxnet/test_utils.py index 6d1749b1a611..bbb12dd5d7af 100644 --- a/python/mxnet/test_utils.py +++ b/python/mxnet/test_utils.py @@ -1926,7 +1926,7 @@ def chi_square_check(generator, buckets, probs, nsamples=1000000): _, p = ss.chisquare(f_obs=obs_freq, f_exp=expected_freq) return p, obs_freq, expected_freq -def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.25, alpha=0.05): +def verify_generator(generator, buckets, probs, nsamples=1000000, nrepeat=5, success_rate=0.2, alpha=0.05): """Verify whether the generator is correct using chi-square testing. The test is repeated for "nrepeat" times and we check if the success rate is diff --git a/tests/python/unittest/test_random.py b/tests/python/unittest/test_random.py index 7910a8f83e2b..7a097150189c 100644 --- a/tests/python/unittest/test_random.py +++ b/tests/python/unittest/test_random.py @@ -577,14 +577,13 @@ def test_poisson_generator(): buckets = [(-1.0, lam - 0.5), (lam - 0.5, 2 * lam + 0.5), (2 * lam + 0.5, np.inf)] probs = [ss.poisson.cdf(bucket[1], lam) - ss.poisson.cdf(bucket[0], lam) for bucket in buckets] generator_mx = lambda x: mx.nd.random.poisson(lam, shape=x, ctx=ctx, dtype=dtype).asnumpy() - verify_generator(generator=generator_mx, buckets=buckets, probs=probs, success_rate=0.2) + verify_generator(generator=generator_mx, buckets=buckets, probs=probs) generator_mx_same_seed = \ lambda x: np.concatenate( [mx.nd.random.poisson(lam, shape=x // 10, ctx=ctx, dtype=dtype).asnumpy() for _ in range(10)]) - verify_generator(generator=generator_mx_same_seed, buckets=buckets, probs=probs, success_rate=0.2) + verify_generator(generator=generator_mx_same_seed, buckets=buckets, probs=probs) -@unittest.skip("Flaky test. Tracked in https://github.com/apache/incubator-mxnet/issues/13506") @with_seed() def test_negative_binomial_generator(): ctx = mx.context.current_context() From 379aed2d85d2ca7519a5a0ab8949a316bb866a56 Mon Sep 17 00:00:00 2001 From: stu1130 Date: Tue, 2 Apr 2019 14:36:19 -0700 Subject: [PATCH 3/3] reenable the test --- tests/python/unittest/test_random.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/python/unittest/test_random.py b/tests/python/unittest/test_random.py index 7a097150189c..8fbd97d8a162 100644 --- a/tests/python/unittest/test_random.py +++ b/tests/python/unittest/test_random.py @@ -568,7 +568,6 @@ def test_exponential_generator(): for _ in range(10)]) verify_generator(generator=generator_mx_same_seed, buckets=buckets, probs=probs, success_rate=0.20) -@unittest.skip("Flaky test. Tracked in https://github.com/apache/incubator-mxnet/issues/13584") @with_seed() def test_poisson_generator(): ctx = mx.context.current_context()