From 8053f8465a1d52801d36fb51178efd1049650cc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Elek?= Date: Sun, 13 Oct 2019 10:46:43 +0200 Subject: [PATCH 1/4] HDDS-2289. Put testing information and a problem description to the github PR template --- .github/pull_request_template.md | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2b5014b7b234..6c7b2b70abab 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,16 @@ -## NOTICE +## What changes were proposed in this pull request? -Please create an issue in ASF JIRA before opening a pull request, +(Please fill in changes proposed in this fix) + +## What is the link to the Apache JIRA + +(Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with -the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.) -For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute +the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY. + +Pease replace this section with the link to the original pull request) + +## How was this patch tested? + +(Please explain how this patch was tested. Ex: unit tests, manual tests) +(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) From 5737c8f261160f9dc88e662f2ebb4da86348401b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elek=2C=20M=C3=A1rton?= Date: Mon, 14 Oct 2019 10:50:55 +0200 Subject: [PATCH 2/4] Update .github/pull_request_template.md Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6c7b2b70abab..c64c9c9c9028 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,7 +6,7 @@ (Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with -the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY. +the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.) Pease replace this section with the link to the original pull request) From 282e2f28ed0a54a9e767e4790d283ccfd1e84b0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elek=2C=20M=C3=A1rton?= Date: Mon, 14 Oct 2019 10:51:07 +0200 Subject: [PATCH 3/4] Typo fix Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c64c9c9c9028..cb320fcd902a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.) -Pease replace this section with the link to the original pull request) +Please replace this section with the link to the original pull request) ## How was this patch tested? From c3c3fb7cc28adf0eaabab5cc3d3f5d24a6a7c165 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Elek?= Date: Mon, 14 Oct 2019 10:52:50 +0200 Subject: [PATCH 4/4] fix text to use link to the Apahce JIRA --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index cb320fcd902a..08001fb962e5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.) -Please replace this section with the link to the original pull request) +Please replace this section with the link to the Apache JIRA) ## How was this patch tested?