From f963683e31eaefc6581ba49dcb64c2236851bd82 Mon Sep 17 00:00:00 2001
From: jianghuazhu <740087514@qq.com>
Date: Wed, 7 Aug 2024 13:41:15 +0800
Subject: [PATCH 1/2] HDDS-11287. Code cleanup in XceiverClientSpi

---
 .../org/apache/hadoop/hdds/scm/XceiverClientGrpc.java     | 8 +++-----
 .../java/org/apache/hadoop/hdds/scm/XceiverClientSpi.java | 6 ++----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
index c46805654779..500b2afd014c 100644
--- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
+++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
@@ -176,8 +176,8 @@ private synchronized void connectToDatanode(DatanodeDetails dn)
 
     // Add credential context to the client call
     if (LOG.isDebugEnabled()) {
-      LOG.debug("Nodes in pipeline : {}", pipeline.getNodes());
-      LOG.debug("Connecting to server : {}", dn.getIpAddress());
+      LOG.debug("Nodes in pipeline : {}, connecting to server : {}",
+          pipeline.getNodes(), dn.getIpAddress());
     }
     ManagedChannel channel = createChannel(dn, port).build();
     XceiverClientProtocolServiceStub asyncStub =
@@ -320,7 +320,6 @@ public ContainerCommandResponseProto sendCommand(
   /**
    * @param request
    * @param dn
-   * @param pipeline
    * In case of getBlock for EC keys, it is required to set replicaIndex for
    * every request with the replicaIndex for that DN for which the request is
    * sent to. This method unpacks proto and reconstructs request after setting
@@ -345,8 +344,7 @@ public ContainerCommandResponseProto sendCommand(
       ContainerCommandRequestProto request, List<Validator> validators)
       throws IOException {
     try {
-      XceiverClientReply reply;
-      reply = sendCommandWithTraceIDAndRetry(request, validators);
+      XceiverClientReply reply = sendCommandWithTraceIDAndRetry(request, validators);
       return reply.getResponse().get();
     } catch (ExecutionException e) {
       throw getIOExceptionForSendCommand(request, e);
diff --git a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientSpi.java b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientSpi.java
index 71d309dee6b3..f6529e84bdc1 100644
--- a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientSpi.java
+++ b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientSpi.java
@@ -110,8 +110,7 @@ public int getRefcount() {
   public ContainerCommandResponseProto sendCommand(
       ContainerCommandRequestProto request) throws IOException {
     try {
-      XceiverClientReply reply;
-      reply = sendCommandAsync(request);
+      XceiverClientReply reply = sendCommandAsync(request);
       return reply.getResponse().get();
     } catch (InterruptedException e) {
       // Re-interrupt the thread while catching InterruptedException
@@ -134,8 +133,7 @@ public ContainerCommandResponseProto sendCommand(
       List<Validator> validators)
       throws IOException {
     try {
-      XceiverClientReply reply;
-      reply = sendCommandAsync(request);
+      XceiverClientReply reply = sendCommandAsync(request);
       ContainerCommandResponseProto responseProto = reply.getResponse().get();
       for (Validator function : validators) {
         function.accept(request, responseProto);

From 3a8d836e5452251fcfd5c871e570ebfaba792e7f Mon Sep 17 00:00:00 2001
From: jianghuazhu <740087514@qq.com>
Date: Wed, 7 Aug 2024 19:37:55 +0800
Subject: [PATCH 2/2] Update some code

---
 .../java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
index 500b2afd014c..e22b47d7ce20 100644
--- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
+++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
@@ -174,10 +174,9 @@ private synchronized void connectToDatanode(DatanodeDetails dn)
           OzoneConfigKeys.HDDS_CONTAINER_IPC_PORT_DEFAULT);
     }
 
-    // Add credential context to the client call
     if (LOG.isDebugEnabled()) {
-      LOG.debug("Nodes in pipeline : {}, connecting to server : {}",
-          pipeline.getNodes(), dn.getIpAddress());
+      LOG.debug("Connecting to server : {}; nodes in pipeline : {}, ",
+          dn, pipeline.getNodes());
     }
     ManagedChannel channel = createChannel(dn, port).build();
     XceiverClientProtocolServiceStub asyncStub =