From 1a10ecfed1ed1982522045da22c05047e5f18a75 Mon Sep 17 00:00:00 2001 From: "Doroszlai, Attila" Date: Fri, 13 Sep 2024 11:45:09 +0200 Subject: [PATCH 1/2] HDDS-11458. Selective checks: trigger checkstyle for properties file changes --- dev-support/ci/selective_ci_checks.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/dev-support/ci/selective_ci_checks.sh b/dev-support/ci/selective_ci_checks.sh index e512b4a5d626..f6b06326a320 100755 --- a/dev-support/ci/selective_ci_checks.sh +++ b/dev-support/ci/selective_ci_checks.sh @@ -373,6 +373,7 @@ function check_needs_checkstyle() { "^hadoop-hdds/dev-support/checkstyle" "pom.xml" "src/..../java" + "src/..../resources/.*\.properties" ) local ignore_array=( "^hadoop-ozone/dist" From db3882e723801a39d3969997636889e7af43b240 Mon Sep 17 00:00:00 2001 From: "Doroszlai, Attila" Date: Fri, 13 Sep 2024 14:17:02 +0200 Subject: [PATCH 2/2] add test case --- dev-support/ci/selective_ci_checks.bats | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/dev-support/ci/selective_ci_checks.bats b/dev-support/ci/selective_ci_checks.bats index a95a981bdd3e..12a7987ffb41 100644 --- a/dev-support/ci/selective_ci_checks.bats +++ b/dev-support/ci/selective_ci_checks.bats @@ -429,3 +429,15 @@ load bats-assert/load.bash assert_output -p needs-integration-tests=false assert_output -p needs-kubernetes-tests=false } + +@test "properties file in resources" { + run dev-support/ci/selective_ci_checks.sh 71b8bdd8becf72d6f7d4e7986895504b8259b3e5 + + assert_output -p 'basic-checks=["rat","checkstyle","native"]' + assert_output -p needs-build=false + assert_output -p needs-compile=false + assert_output -p needs-compose-tests=false + assert_output -p needs-dependency-check=false + assert_output -p needs-integration-tests=true + assert_output -p needs-kubernetes-tests=false +}