From 15b220b80ff749a6fc2ce532a207ffbf910ece7d Mon Sep 17 00:00:00 2001 From: Gargi Jaiswal Date: Mon, 21 Apr 2025 14:36:48 +0530 Subject: [PATCH] Used AtomicFileOutputStream in DiskBalancerYaml file. --- .../container/diskbalancer/DiskBalancerYaml.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java index e7c35452436e..381efdd08e46 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerYaml.java @@ -20,9 +20,10 @@ import java.io.File; import java.io.IOException; import java.io.InputStream; -import java.io.Writer; import java.nio.file.Files; import org.apache.hadoop.hdds.server.YamlUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.yaml.snakeyaml.DumperOptions; import org.yaml.snakeyaml.Yaml; @@ -32,6 +33,9 @@ public final class DiskBalancerYaml { + private static final Logger LOG = + LoggerFactory.getLogger(DiskBalancerYaml.class); + private DiskBalancerYaml() { // static helper methods only, no state. } @@ -50,9 +54,8 @@ public static void createDiskBalancerInfoFile( options.setDefaultFlowStyle(DumperOptions.FlowStyle.FLOW); Yaml yaml = new Yaml(options); - try (Writer writer = Files.newBufferedWriter(path.toPath())) { - yaml.dump(getDiskBalancerInfoYaml(diskBalancerInfo), writer); - } + final DiskBalancerInfoYaml data = getDiskBalancerInfoYaml(diskBalancerInfo); + YamlUtils.dump(yaml, data, path, LOG); } /**