From 969a381782a5ecbefb351ec04ae2e58c3805d0f7 Mon Sep 17 00:00:00 2001
From: Matteo Merli <mmerli@apache.org>
Date: Fri, 14 Oct 2022 10:48:16 -0700
Subject: [PATCH 1/2] Fixed validation of cluster/namespace names containing
 legal non-alpha characters

---
 lib/NamedEntity.cc         | 24 +++++++++++++++++-------
 tests/NamespaceNameTest.cc |  8 ++++++++
 tests/TopicNameTest.cc     | 10 ++++++++++
 3 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/lib/NamedEntity.cc b/lib/NamedEntity.cc
index ad7c385c..484c8b1f 100644
--- a/lib/NamedEntity.cc
+++ b/lib/NamedEntity.cc
@@ -18,19 +18,29 @@
  */
 #include "NamedEntity.h"
 
+#include <cctype>
+
+/**
+ * Allowed characters for property, namespace, cluster and topic names are
+ * alphanumeric (a-zA-Z_0-9) and these special chars -=:.
+ * @param name
+ * @return
+ */
 bool NamedEntity::checkName(const std::string& name) {
     for (char c : name) {
+        if (isalnum(c)) {
+            continue;
+        }
+
         switch (c) {
+            case '-':
             case '=':
             case ':':
-            case ' ':
-            case '!':
-            case '\t':
-            case '\r':
-            case '\n':
-                return false;
+            case '.':
+                continue;
             default:
-                break;
+                // Invalid character was found
+                return false;
         }
     }
 
diff --git a/tests/NamespaceNameTest.cc b/tests/NamespaceNameTest.cc
index 85a57494..51975c82 100644
--- a/tests/NamespaceNameTest.cc
+++ b/tests/NamespaceNameTest.cc
@@ -42,3 +42,11 @@ TEST(NamespaceNameTest, testNamespaceNameV2) {
     std::shared_ptr<NamespaceName> nn2 = NamespaceName::get("property", "namespace");
     ASSERT_TRUE(*nn1 == *nn2);
 }
+
+TEST(NamespaceNameTest, testNamespaceNameLegalCharacters) {
+    std::shared_ptr<NamespaceName> nn1 = NamespaceName::get("cluster-1:=.", "namespace-1:=.");
+    ASSERT_EQ("cluster-1:=.", nn1->getProperty());
+    ASSERT_TRUE(nn1->getCluster().empty());
+    ASSERT_EQ("namespace-1:=.", nn1->getLocalName());
+    ASSERT_TRUE(nn1->isV2());
+}
diff --git a/tests/TopicNameTest.cc b/tests/TopicNameTest.cc
index 377a9319..38d7859e 100644
--- a/tests/TopicNameTest.cc
+++ b/tests/TopicNameTest.cc
@@ -140,6 +140,16 @@ TEST(TopicNameTest, testIllegalCharacters) {
     ASSERT_FALSE(topicName);
 }
 
+TEST(TopicNameTest, testLegalNonAlphaCharacters) {
+    std::shared_ptr<TopicName> topicName =
+        TopicName::get("persistent://cluster-1:=./namespace-1:=./topic");
+    ASSERT_TRUE(topicName);
+    ASSERT_EQ("cluster-1:=.", topicName->getProperty());
+    ASSERT_EQ("namespace-1:=.", topicName->getNamespacePortion());
+    ASSERT_EQ("persistent", topicName->getDomain());
+    ASSERT_EQ("topic", topicName->getLocalName());
+}
+
 TEST(TopicNameTest, testIllegalUrl) {
     std::shared_ptr<TopicName> topicName = TopicName::get("persistent:::/property/cluster/namespace/topic");
     ASSERT_FALSE(topicName);

From ed893c48f2ed924477eb295a7b449c28844d4a2c Mon Sep 17 00:00:00 2001
From: Matteo Merli <mmerli@apache.org>
Date: Fri, 14 Oct 2022 11:02:07 -0700
Subject: [PATCH 2/2] Fixed formatting

---
 tests/TopicNameTest.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TopicNameTest.cc b/tests/TopicNameTest.cc
index 38d7859e..3db2a6c0 100644
--- a/tests/TopicNameTest.cc
+++ b/tests/TopicNameTest.cc
@@ -141,8 +141,7 @@ TEST(TopicNameTest, testIllegalCharacters) {
 }
 
 TEST(TopicNameTest, testLegalNonAlphaCharacters) {
-    std::shared_ptr<TopicName> topicName =
-        TopicName::get("persistent://cluster-1:=./namespace-1:=./topic");
+    std::shared_ptr<TopicName> topicName = TopicName::get("persistent://cluster-1:=./namespace-1:=./topic");
     ASSERT_TRUE(topicName);
     ASSERT_EQ("cluster-1:=.", topicName->getProperty());
     ASSERT_EQ("namespace-1:=.", topicName->getNamespacePortion());