From aa7d43f7da1b1c498c0a6511a18fcfcfa523bfa8 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 31 Aug 2016 15:57:12 +0900 Subject: [PATCH 1/4] Verbose the build comment in WINDOWS.md --- R/WINDOWS.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/R/WINDOWS.md b/R/WINDOWS.md index f67a1c51d1785..efbfed10e6682 100644 --- a/R/WINDOWS.md +++ b/R/WINDOWS.md @@ -4,13 +4,21 @@ To build SparkR on Windows, the following steps are required 1. Install R (>= 3.1) and [Rtools](http://cran.r-project.org/bin/windows/Rtools/). Make sure to include Rtools and R in `PATH`. + 2. Install [JDK7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html) and set `JAVA_HOME` in the system environment variables. + 3. Download and install [Maven](http://maven.apache.org/download.html). Also include the `bin` directory in Maven in `PATH`. + 4. Set `MAVEN_OPTS` as described in [Building Spark](http://spark.apache.org/docs/latest/building-spark.html). -5. Open a command shell (`cmd`) in the Spark directory and run `mvn -DskipTests -Psparkr package` + +5. Open a command shell (`cmd`) in the Spark directory and build Spark with [Maven](http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn) and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run + + ```bash + build/mvn -DskipTests -Psparkr package + ``` ## Unit tests From 152db1bb078e83cf7aa5f753eaad22ce6798ef67 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 31 Aug 2016 16:11:25 +0900 Subject: [PATCH 2/4] Fix doc (not using shell build/mvn) --- R/WINDOWS.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/R/WINDOWS.md b/R/WINDOWS.md index efbfed10e6682..8edcd982c0888 100644 --- a/R/WINDOWS.md +++ b/R/WINDOWS.md @@ -17,9 +17,11 @@ directory in Maven in `PATH`. 5. Open a command shell (`cmd`) in the Spark directory and build Spark with [Maven](http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn) and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run ```bash - build/mvn -DskipTests -Psparkr package + mvn -DskipTests -Psparkr package ``` + `build/mvn` is a shell script so `mvn` should be used directly on Windows. + ## Unit tests To run the SparkR unit tests on Windows, the following steps are required —assuming you are in the Spark root directory and do not have Apache Hadoop installed already: From f17e12cbc233219f103746e04926cb707ad8d526 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 31 Aug 2016 16:13:02 +0900 Subject: [PATCH 3/4] Window paths --- R/WINDOWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/WINDOWS.md b/R/WINDOWS.md index 8edcd982c0888..25d90e3237f48 100644 --- a/R/WINDOWS.md +++ b/R/WINDOWS.md @@ -20,7 +20,7 @@ directory in Maven in `PATH`. mvn -DskipTests -Psparkr package ``` - `build/mvn` is a shell script so `mvn` should be used directly on Windows. + `.\build\mvn` is a shell script so `mvn` should be used directly on Windows. ## Unit tests From 633a9f6365da19c2ea613d7c96020e65a2fa5059 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 31 Aug 2016 17:57:17 +0900 Subject: [PATCH 4/4] Use mvn.cmd rather than mvn as described in official Maven documenation --- R/WINDOWS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/WINDOWS.md b/R/WINDOWS.md index 25d90e3237f48..1afcbfcabe85f 100644 --- a/R/WINDOWS.md +++ b/R/WINDOWS.md @@ -17,10 +17,10 @@ directory in Maven in `PATH`. 5. Open a command shell (`cmd`) in the Spark directory and build Spark with [Maven](http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn) and include the `-Psparkr` profile to build the R package. For example to use the default Hadoop versions you can run ```bash - mvn -DskipTests -Psparkr package + mvn.cmd -DskipTests -Psparkr package ``` - `.\build\mvn` is a shell script so `mvn` should be used directly on Windows. + `.\build\mvn` is a shell script so `mvn.cmd` should be used directly on Windows. ## Unit tests