From 6646e47c44a9d265c5be317210c6981496f180dc Mon Sep 17 00:00:00 2001 From: byungsoo Date: Thu, 29 Apr 2021 15:26:32 +0900 Subject: [PATCH 1/2] Fix error in BenchmarkBase.scala that occurs when creating benchmark files in non-existent directory --- .../scala/org/apache/spark/benchmark/BenchmarkBase.scala | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala b/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala index cce58c35f90ea..c2722a5de0b38 100644 --- a/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala +++ b/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala @@ -49,7 +49,11 @@ abstract class BenchmarkBase { val resultFileName = s"${this.getClass.getSimpleName.replace("$", "")}$jdkString$suffix-results.txt" val prefix = Benchmarks.currentProjectRoot.map(_ + "/").getOrElse("") - val file = new File(s"${prefix}benchmarks/$resultFileName") + val dir = new File(s"${prefix}benchmarks/") + if (!dir.exists()) { + dir.mkdirs() + } + val file = new File(s"${dir}$resultFileName") if (!file.exists()) { file.createNewFile() } From fcf9fe29b7452f623252870e195db9b777cf5860 Mon Sep 17 00:00:00 2001 From: byungsoo Date: Mon, 3 May 2021 15:33:47 +0900 Subject: [PATCH 2/2] Add message when creating directory --- .../test/scala/org/apache/spark/benchmark/BenchmarkBase.scala | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala b/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala index c2722a5de0b38..9b42a2772ba17 100644 --- a/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala +++ b/core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala @@ -51,6 +51,9 @@ abstract class BenchmarkBase { val prefix = Benchmarks.currentProjectRoot.map(_ + "/").getOrElse("") val dir = new File(s"${prefix}benchmarks/") if (!dir.exists()) { + // scalastyle:off println + println(s"Creating ${dir.getAbsolutePath} for benchmark results.") + // scalastyle:on println dir.mkdirs() } val file = new File(s"${dir}$resultFileName")