Skip to content

Commit a7d8e76

Browse files
committed
refactor(DependencyList): simplify onCheckChanged logic by removing redundant conditions
1 parent 24518d9 commit a7d8e76

1 file changed

Lines changed: 7 additions & 13 deletions

File tree

  • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -204,21 +204,15 @@ const DependencyList = ({
204204
}
205205
}, [availableFilters, dependencies, onDependenciesChange]);
206206

207-
const onCheckChanged = (value: boolean) => {
208-
if (value) {
209-
// When enabling dependencies, add a suggestion if no dependencies exist
210-
if (!hasDependencies && hasAvailableFilters) {
211-
const suggestion = getDependencySuggestion();
212-
if (suggestion) {
213-
onDependenciesChange([suggestion]);
214-
}
207+
const onCheckChanged = (value: boolean) => {
208+
const newDependencies: string[] = [];
209+
if (value && !hasDependencies && hasAvailableFilters) {
210+
const suggestion = getDependencySuggestion()
211+
if(suggestion) {
212+
newDependencies.push(suggestion);
215213
}
216-
// If no available filters or suggestion, keep the checkbox checked but with empty dependencies
217-
// This prevents the checkbox from immediately closing due to lack of available filters
218-
} else {
219-
// When disabling dependencies, clear all dependencies
220-
onDependenciesChange([]);
221214
}
215+
onDependenciesChange(newDependencies);
222216
};
223217

224218
return (

0 commit comments

Comments
 (0)