From fc30328c50cb0d2ed3059ea2f8d3b11fad60bc35 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 17 Sep 2020 22:01:55 -0700 Subject: [PATCH 1/5] ignore docs on several actions, give docs its own action --- .github/workflows/prefer-typescript.yml | 2 ++ .github/workflows/superset-docs.yml | 30 +++++++++++++++++++++++++ .github/workflows/superset-e2e.yml | 8 ++++++- .github/workflows/superset-frontend.yml | 24 ++++++-------------- .github/workflows/superset-python.yml | 8 ++++++- .github/workflows/test-hive.yml | 8 ++++++- .github/workflows/test-presto.yml | 8 ++++++- 7 files changed, 67 insertions(+), 21 deletions(-) create mode 100644 .github/workflows/superset-docs.yml diff --git a/.github/workflows/prefer-typescript.yml b/.github/workflows/prefer-typescript.yml index d2fff6e4565b..4cf401f73a32 100644 --- a/.github/workflows/prefer-typescript.yml +++ b/.github/workflows/prefer-typescript.yml @@ -2,6 +2,8 @@ name: Prefer TypeScript on: pull_request: + paths-ignore: + - 'docs/**' branches: - master diff --git a/.github/workflows/superset-docs.yml b/.github/workflows/superset-docs.yml new file mode 100644 index 000000000000..56d857ceb097 --- /dev/null +++ b/.github/workflows/superset-docs.yml @@ -0,0 +1,30 @@ +name: Docs + +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' + +jobs: + docs: + name: build + runs-on: ubuntu-18.04 + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Install dependencies + - name: npm install + working-directory: ./docs + run: | + npm install + - name: lint + working-directory: ./docs + run: | + npm run lint + - name: gatsby build + working-directory: ./docs + run: | + npm run build diff --git a/.github/workflows/superset-e2e.yml b/.github/workflows/superset-e2e.yml index dfa691058ac6..f634e1544cc2 100644 --- a/.github/workflows/superset-e2e.yml +++ b/.github/workflows/superset-e2e.yml @@ -1,6 +1,12 @@ name: E2E -on: [push, pull_request] +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: Cypress: diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index 8ddaa3b70f71..0f0b5db48548 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -1,6 +1,12 @@ name: Frontend -on: [push, pull_request] +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: build: @@ -25,19 +31,3 @@ jobs: working-directory: ./superset-frontend run: | bash <(curl -s https://codecov.io/bash) -cF javascript - - docs: - name: build - runs-on: ubuntu-18.04 - steps: - - name: Checkout code - uses: actions/checkout@v2 - - name: Install dependencies - - name: npm install - working-directory: ./superset-frontend - run: | - npm install - - name: gatsby build - working-directory: ./superset-frontend - run: | - npm run build diff --git a/.github/workflows/superset-python.yml b/.github/workflows/superset-python.yml index 6bfe3772185a..5da41d9f5c93 100644 --- a/.github/workflows/superset-python.yml +++ b/.github/workflows/superset-python.yml @@ -1,7 +1,13 @@ # Python unit tests name: Python -on: [push, pull_request] +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: lint: diff --git a/.github/workflows/test-hive.yml b/.github/workflows/test-hive.yml index 2571f4a2f85e..b372be4519f5 100644 --- a/.github/workflows/test-hive.yml +++ b/.github/workflows/test-hive.yml @@ -1,6 +1,12 @@ name: Hive -on: [push, pull_request] +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: test-postgres-hive: diff --git a/.github/workflows/test-presto.yml b/.github/workflows/test-presto.yml index 14ac0a8f5eaf..360026b056cf 100644 --- a/.github/workflows/test-presto.yml +++ b/.github/workflows/test-presto.yml @@ -1,6 +1,12 @@ name: Presto -on: [push, pull_request] +on: + push: + paths-ignore: + - 'docs/**' + pull_request: + paths-ignore: + - 'docs/**' jobs: test-postgres-presto: From 01e35190af16e8a35189a4911c7c089dc26dffbf Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 17 Sep 2020 22:09:31 -0700 Subject: [PATCH 2/5] Random doc change to see if the new action runs. --- docs/src/pages/404.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/pages/404.jsx b/docs/src/pages/404.jsx index 325d51aa61be..12b044ad47c1 100644 --- a/docs/src/pages/404.jsx +++ b/docs/src/pages/404.jsx @@ -25,7 +25,7 @@ const NotFoundPage = () => (

NOT FOUND

-

You just hit a route that does not exist... the sadness.

+

Sorry, you've requested a page that does not exist.

); From c0e4c54693e7dd1472b4797ba1940ae4e0e1dd36 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 17 Sep 2020 22:12:59 -0700 Subject: [PATCH 3/5] umm... not paths-ignore, paths! --- .github/workflows/superset-docs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/superset-docs.yml b/.github/workflows/superset-docs.yml index 56d857ceb097..95039732a1c4 100644 --- a/.github/workflows/superset-docs.yml +++ b/.github/workflows/superset-docs.yml @@ -2,10 +2,10 @@ name: Docs on: push: - paths-ignore: + paths: - 'docs/**' pull_request: - paths-ignore: + paths: - 'docs/**' jobs: From 350541450d57dbf6579c3c286e522cf3f56f7d73 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 17 Sep 2020 22:17:28 -0700 Subject: [PATCH 4/5] eof fix --- .github/workflows/superset-frontend.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index 948dc1738bfd..0f0b5db48548 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -30,4 +30,4 @@ jobs: - name: Upload code coverage working-directory: ./superset-frontend run: | - bash <(curl -s https://codecov.io/bash) -cF javascript \ No newline at end of file + bash <(curl -s https://codecov.io/bash) -cF javascript From b217efa41b99c19831fd081471cb80e9bd182d6f Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 18 Sep 2020 10:17:59 -0700 Subject: [PATCH 5/5] enabling typescript checking on docs --- .github/workflows/prefer-typescript.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/prefer-typescript.yml b/.github/workflows/prefer-typescript.yml index 4cf401f73a32..d2fff6e4565b 100644 --- a/.github/workflows/prefer-typescript.yml +++ b/.github/workflows/prefer-typescript.yml @@ -2,8 +2,6 @@ name: Prefer TypeScript on: pull_request: - paths-ignore: - - 'docs/**' branches: - master