From 05a1bb7793e4c3447a046373ab654217920bd487 Mon Sep 17 00:00:00 2001
From: Elizabeth Thompson
+ Need help? Learn more about connecting to {name}.
+ {label}Enter the required {name} credentials
+
{label}
-- Need help? Learn more about connecting to {name}. -
-+ Need help? Learn more about connecting to {name}. +
+{label}
); diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index 5cecee788006..92f07cd13694 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -297,7 +297,7 @@ const DatabaseModal: FunctionComponentTODO: form
-{label}
-{label}
-Step 1 of 3
+- Need help? Learn more about connecting to {name}. -
-+ Need help? Learn more about connecting to {name}. +
+Step 2 of 2
+Step 2 of 3
Need help? Learn more about connecting to {name}.
From b8e668712e64993e700e83f7b3b76a44bf515969 Mon Sep 17 00:00:00 2001
From: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Date: Thu, 3 Jun 2021 16:39:50 -0400
Subject: [PATCH 048/145] feat: Dynamic Form for edit DB Modal (#14845)
* split db modal file
* split db modal file
* hook up available databases
* add comment
* split db modal file
* hook up available databases
* use new validation component
* first draft
* use new validation component
* get tests passing
* split db modal file
* hook up available databases
* use new validation component
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* revisions
* fix package-lock.json
* # This is a combination of 6 commits.
# This is the 1st commit message:
feat: validation db modal (#14832)
* split db modal file
* hook up available databases
* use new validation component
# This is the commit message #2:
feat: Icon Button (#14818)
* Creating IconButton
* Changed naming: logo is now icon
* Hard-coded inset values for ellipses
* Removed default SVG
* Fixed test
* Removed logo from test
# This is the commit message #3:
chore: Improves the native filters UI/UX - iteration 6 (#14932)
# This is the commit message #4:
fix: is_temporal should overwrite is_dttm (#14894)
* fix: is_temporal should overwrite is_dttm
* move up
# This is the commit message #5:
fix: time parser truncate to first day of year/month (#14945)
# This is the commit message #6:
hook up available databases
* fix test for db modal
* feat(db-connection-ui): Allow users to pick engine (#14884)
* poc picker for db selection
* working select
* setup is loading for available dbs and step1 view
* fix on close
* update on fetch
* remove unneeded code
* add some styls
* more revisions
* used db.backend
* added engine to model
* elizabeth revisions
* elizabeth revisions
Co-authored-by: Elizabeth Thompson TODO: form Step 2 of 3
- Need help? Learn more about connecting to {name}.
-
+ Need help? Learn more about connecting to {name}.
+
- Need help? Learn more about connecting to {name}.
- Step 2 of 2 Step 3 of 3
+ Need help? Learn more about{' '}
+
+ connecting to {dbModel.name}
+
+ Step 2 of 3
+ Need help? Learn more about connecting to {dbModel.name}.
+ Step 1 of 3 Step 2 of 2 Step 1 of 3 Enter the required {name} credentials
- Enter the required {name} credentials
+
+ {icon &&
}
+ {!icon && (
+
Enter the required {name} credentials
-
+ Your database was successfully connected! Here are some optional
+ settings for your database
+
+ Enter the required {dbModel.name} credentials
+ Select a database to connect
+
Select a database to connect
-
- Configure how this database will function in SQL Lab. + Adjust how this database will interact with SQL Lab.
- Adjust settings that will impact the performance of this database. + Adjust performance settings of this database.
Additional settings.
+Additional settings.
+