fix: Could not remove metrics in Explore#22936
Closed
geido wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22936 +/- ##
===========================================
- Coverage 67.37% 56.35% -11.02%
===========================================
Files 1876 1876
Lines 72061 72061
Branches 7864 7864
===========================================
- Hits 48550 40613 -7937
- Misses 21491 29428 +7937
Partials 2020 2020
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR #22707 moved the
stopPropagationevent downstream but wasn't removed upstream causing a bug with removing metrics.BEFORE
215146205-c9f67d24-ffae-4135-893a-6f6a5b389fb0.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION