From 0e6f83117a86c6538e4df9598bdc62370b4a52c2 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 9 Apr 2019 23:12:33 -0700 Subject: [PATCH 1/2] Add all database access permission to 'Alpha' role --- superset/security.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/security.py b/superset/security.py index 3a766d4e1d33..d2208e6de005 100644 --- a/superset/security.py +++ b/superset/security.py @@ -68,7 +68,6 @@ class SupersetSecurityManager(SecurityManager): } ADMIN_ONLY_PERMISSIONS = { - 'all_database_access', 'can_sql_json', # TODO: move can_sql_json to sql_lab role 'can_override_role_permissions', 'can_sync_druid_source', @@ -84,6 +83,7 @@ class SupersetSecurityManager(SecurityManager): ALPHA_ONLY_PERMISSIONS = set([ 'muldelete', + 'all_database_access', 'all_datasource_access', ]) From 8d1fe6740d76a72b0e6cd91096e252e71254f881 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 10 Apr 2019 08:12:56 -0700 Subject: [PATCH 2/2] Grant all database access to Alpha --- tests/security_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/security_tests.py b/tests/security_tests.py index 423b58bee133..063f1e8abf98 100644 --- a/tests/security_tests.py +++ b/tests/security_tests.py @@ -129,9 +129,6 @@ def test_is_admin_only(self): self.assertTrue(security_manager.is_admin_only( security_manager.find_permission_view_menu( 'can_approve', 'Superset'))) - self.assertTrue(security_manager.is_admin_only( - security_manager.find_permission_view_menu( - 'all_database_access', 'all_database_access'))) def test_is_alpha_only(self): self.assertFalse(security_manager.is_alpha_only( @@ -148,6 +145,9 @@ def test_is_alpha_only(self): self.assertTrue(security_manager.is_alpha_only( security_manager.find_permission_view_menu( 'can_delete', 'DruidMetricInlineView'))) + self.assertTrue(security_manager.is_alpha_only( + security_manager.find_permission_view_menu( + 'all_database_access', 'all_database_access'))) def test_is_gamma_pvm(self): self.assertTrue(security_manager.is_gamma_pvm(