From 14e71a0b06f3bc2b33dea5cb2f46b1736b5c183d Mon Sep 17 00:00:00 2001 From: khtruong Date: Mon, 22 Apr 2019 15:09:58 -0700 Subject: [PATCH] fix: do not save colors without a color scheme --- superset/assets/src/dashboard/components/Header.jsx | 2 +- superset/assets/src/dashboard/components/SaveModal.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/assets/src/dashboard/components/Header.jsx b/superset/assets/src/dashboard/components/Header.jsx index 92d3b1df62ba..8f3f831e3fd2 100644 --- a/superset/assets/src/dashboard/components/Header.jsx +++ b/superset/assets/src/dashboard/components/Header.jsx @@ -222,7 +222,7 @@ class Header extends React.PureComponent { colorScheme, colorNamespace, ); - const labelColors = scale.getColorMap(); + const labelColors = colorScheme ? scale.getColorMap() : {}; const data = { positions, expanded_slices: expandedSlices, diff --git a/superset/assets/src/dashboard/components/SaveModal.jsx b/superset/assets/src/dashboard/components/SaveModal.jsx index 1873f0c3133a..d926bc8aa55d 100644 --- a/superset/assets/src/dashboard/components/SaveModal.jsx +++ b/superset/assets/src/dashboard/components/SaveModal.jsx @@ -110,7 +110,7 @@ class SaveModal extends React.PureComponent { colorScheme, colorNamespace, ); - const labelColors = scale.getColorMap(); + const labelColors = colorScheme ? scale.getColorMap() : {}; const data = { positions, css,