From 5c795b40d89b7a078342d2d96fa5469cad4069bc Mon Sep 17 00:00:00 2001 From: Thorsten Schoel Date: Fri, 26 Jul 2019 15:05:55 +0200 Subject: [PATCH] Fix tooltips not visible for NVD3 charts on Firefox (#7822) This bug was introduced by #7102 Using `position:absolute` on body gives `document.documentElement` a height of 0 which propagates to `clientHeight` on Firefox. This leads to a wrong calculation of the tooltip position in NVD3. The solution proposed here is to use `min-height: 100vh` instead of the current technique for stretching the body element to the full window height, thus keeping body and html together. --- superset/assets/stylesheets/less/index.less | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/superset/assets/stylesheets/less/index.less b/superset/assets/stylesheets/less/index.less index b1fc604323c0..680c134b5991 100644 --- a/superset/assets/stylesheets/less/index.less +++ b/superset/assets/stylesheets/less/index.less @@ -25,11 +25,7 @@ @stroke-primary: @brand-primary; body { - position: absolute; - top: 0; - right: 0; - bottom: 0; - left: 0; + min-height: 100vh; display: flex; flex-direction: column; }