From e18823839a51c32ab50a883fbd41103bdfaae650 Mon Sep 17 00:00:00 2001 From: Laszlo Bodor Date: Wed, 30 Jul 2025 13:28:49 +0200 Subject: [PATCH 1/2] TEZ-4642: Introduce spotless plugin and enforce basic import styles --- .../tez/hadoop/shim/TestHadoopShim28.java | 1 + .../hadoop/shim/TestHadoopShim28Provider.java | 1 + .../tez/hadoop/shim/HadoopShimsLoader.java | 5 +- .../hadoop/shim/TestHadoopShimsLoader.java | 1 + pom.xml | 27 ++++ .../org/apache/tez/client/CallerContext.java | 1 - .../apache/tez/client/FrameworkClient.java | 5 +- .../java/org/apache/tez/client/TezClient.java | 37 +++--- .../org/apache/tez/client/TezClientUtils.java | 21 +-- .../java/org/apache/tez/common/GuavaShim.java | 4 +- .../apache/tez/common/JavaOptsChecker.java | 1 + .../org/apache/tez/common/ProgressHelper.java | 13 +- .../org/apache/tez/common/TezClassLoader.java | 1 + .../org/apache/tez/common/TezCommonUtils.java | 5 +- .../java/org/apache/tez/common/TezUtils.java | 13 +- .../org/apache/tez/common/TezYARNUtils.java | 5 +- .../org/apache/tez/common/VersionInfo.java | 5 +- .../tez/common/counters/AbstractCounter.java | 3 +- .../tez/common/counters/AbstractCounters.java | 5 +- .../common/counters/CounterGroupFactory.java | 4 +- .../counters/FileSystemCounterGroup.java | 13 +- .../apache/tez/common/counters/Limits.java | 8 +- .../security/ACLConfigurationParser.java | 5 +- .../tez/common/security/ACLManager.java | 2 - .../security/HistoryACLPolicyManager.java | 1 - .../tez/common/security/TokenCache.java | 5 +- .../main/java/org/apache/tez/dag/api/DAG.java | 30 ++--- .../apache/tez/dag/api/DagTypeConverters.java | 6 +- .../tez/dag/api/DataSourceDescriptor.java | 6 +- .../org/apache/tez/dag/api/EdgeProperty.java | 1 - .../apache/tez/dag/api/EntityDescriptor.java | 3 +- .../apache/tez/dag/api/TaskLocationHint.java | 3 +- .../apache/tez/dag/api/TezConfiguration.java | 7 +- .../org/apache/tez/dag/api/UserPayload.java | 4 +- .../java/org/apache/tez/dag/api/Vertex.java | 2 +- .../dag/api/VertexManagerPluginContext.java | 3 +- .../tez/dag/api/client/DAGClientImpl.java | 19 +-- .../dag/api/client/DAGClientTimelineImpl.java | 24 ++-- .../apache/tez/dag/api/client/DAGStatus.java | 2 +- .../dag/api/client/TimelineReaderFactory.java | 23 ++-- .../tez/dag/api/client/VertexStatus.java | 6 +- .../dag/api/client/rpc/DAGClientRPCImpl.java | 15 ++- .../tez/runtime/api/AbstractLogicalInput.java | 1 - .../tez/runtime/api/InputInitializer.java | 3 +- .../runtime/api/InputInitializerContext.java | 5 +- .../tez/runtime/api/MergedLogicalInput.java | 1 - .../tez/runtime/api/OutputCommitter.java | 2 +- .../api/ProcessorFrameworkInterface.java | 4 +- .../api/events/CustomProcessorEvent.java | 5 +- .../api/events/InputInitializerEvent.java | 2 +- .../api/events/InputReadErrorEvent.java | 4 +- .../tez/serviceplugins/api/DagInfo.java | 4 +- .../api/ServicePluginsDescriptor.java | 2 +- .../org/apache/tez/client/TestTezClient.java | 38 +++--- .../apache/tez/client/TestTezClientUtils.java | 1 + .../tez/common/TestJavaOptsChecker.java | 2 +- .../org/apache/tez/common/TestRPCUtil.java | 8 +- .../tez/common/TestReflectionUtils.java | 1 + .../apache/tez/common/TestTezCommonUtils.java | 8 +- .../apache/tez/common/TestTezYARNUtils.java | 7 +- .../security/TestACLConfigurationParser.java | 1 + .../tez/common/security/TestACLManager.java | 1 + .../security/TestDAGAccessControls.java | 5 +- .../tez/common/security/TestTokenCache.java | 1 + .../java/org/apache/tez/dag/api/TestDAG.java | 1 + .../org/apache/tez/dag/api/TestDAGPlan.java | 3 +- .../org/apache/tez/dag/api/TestDAGVerify.java | 7 +- .../tez/dag/api/TestDagTypeConverters.java | 6 +- .../tez/dag/api/TestEntityDescriptor.java | 11 +- .../tez/dag/api/TestHistoryLogLevel.java | 1 + .../tez/dag/api/TestTaskLocationHint.java | 4 +- .../tez/dag/api/TestTezConfiguration.java | 2 +- .../tez/dag/api/client/TestATSHttpClient.java | 1 + .../api/client/TestTimelineReaderFactory.java | 2 +- .../tez/dag/api/client/rpc/TestDAGClient.java | 13 +- .../events/TestInputDataInformationEvent.java | 4 +- .../apache/tez/common/AsyncDispatcher.java | 7 +- .../tez/common/AsyncDispatcherConcurrent.java | 7 +- .../tez/common/DagContainerLauncher.java | 4 +- .../org/apache/tez/common/GcTimeUpdater.java | 2 +- .../org/apache/tez/common/StreamHelper.java | 5 +- .../tez/common/TezLog4jConfigurator.java | 1 - .../apache/tez/common/TezUtilsInternal.java | 21 +-- .../tez/common/web/ProfileOutputServlet.java | 14 +- .../apache/tez/common/web/ProfileServlet.java | 24 ++-- .../org/apache/tez/dag/records/TezDAGID.java | 1 - .../org/apache/tez/dag/records/TezTaskID.java | 1 - .../apache/tez/dag/records/TezVertexID.java | 1 - .../org/apache/tez/util/LoggingUtils.java | 1 + .../tez/util/TezMxBeanResourceCalculator.java | 6 +- .../apache/tez/common/DrainDispatcher.java | 7 +- .../tez/common/TestAsyncDispatcher.java | 1 + .../common/TestAsyncDispatcherConcurrent.java | 1 + .../tez/common/TestTezSharedExecutor.java | 1 + .../org/apache/tez/common/TestTezUtils.java | 11 +- .../apache/tez/dag/records/TestTezIds.java | 5 +- .../org/apache/tez/util/TestNumberFormat.java | 4 +- .../util/TestTezMxBeanResourceCalculator.java | 1 + .../src/main/java/org/apache/tez/Utils.java | 12 +- .../org/apache/tez/client/LocalClient.java | 27 ++-- .../tez/dag/api/client/DAGClientHandler.java | 7 +- .../tez/dag/api/client/DAGClientServer.java | 7 +- .../tez/dag/api/client/DAGStatusBuilder.java | 4 +- .../dag/api/client/VertexStatusBuilder.java | 5 +- ...GClientAMProtocolBlockingPBServerImpl.java | 2 +- .../org/apache/tez/dag/app/AppContext.java | 3 +- .../apache/tez/dag/app/ContainerContext.java | 8 +- .../dag/app/ContainerLauncherContextImpl.java | 13 +- .../org/apache/tez/dag/app/DAGAppMaster.java | 58 ++++----- .../dag/app/DAGAppMasterReadinessService.java | 1 + .../apache/tez/dag/app/RecoveryParser.java | 11 +- .../dag/app/TaskCommunicatorContextImpl.java | 30 +++-- .../tez/dag/app/TaskCommunicatorManager.java | 65 +++++----- .../app/TaskCommunicatorManagerInterface.java | 6 +- .../tez/dag/app/TaskCommunicatorWrapper.java | 5 +- .../dag/app/TezLocalTaskCommunicatorImpl.java | 3 +- .../tez/dag/app/TezTaskCommunicatorImpl.java | 18 +-- .../java/org/apache/tez/dag/app/dag/DAG.java | 6 +- .../app/dag/RootInputInitializerManager.java | 23 ++-- .../tez/dag/app/dag/StateChangeNotifier.java | 19 ++- .../apache/tez/dag/app/dag/TaskAttempt.java | 3 +- .../dag/app/dag/TaskStateUpdateListener.java | 2 - .../org/apache/tez/dag/app/dag/Vertex.java | 8 +- .../dag/event/DAGEventVertexReRunning.java | 1 - .../apache/tez/dag/app/dag/impl/DAGImpl.java | 33 ++--- .../dag/impl/DAGSchedulerNaturalOrder.java | 5 +- .../DAGSchedulerNaturalOrderControlled.java | 12 +- .../org/apache/tez/dag/app/dag/impl/Edge.java | 23 ++-- .../dag/impl/ImmediateStartVertexManager.java | 19 +-- .../dag/app/dag/impl/OneToOneEdgeManager.java | 3 +- .../dag/impl/OneToOneEdgeManagerOnDemand.java | 3 +- .../app/dag/impl/RootInputVertexManager.java | 11 +- .../dag/impl/ScatterGatherEdgeManager.java | 2 +- .../tez/dag/app/dag/impl/TaskAttemptImpl.java | 43 +++--- .../apache/tez/dag/app/dag/impl/TaskImpl.java | 29 ++--- .../TezRootInputInitializerContextImpl.java | 2 +- .../tez/dag/app/dag/impl/VertexImpl.java | 17 +-- .../tez/dag/app/dag/impl/VertexManager.java | 25 ++-- .../VertexShuffleDataDeletionContext.java | 4 +- .../speculation/legacy/LegacySpeculator.java | 14 +- ...SimpleExponentialTaskRuntimeEstimator.java | 2 +- .../forecast/SimpleExponentialSmoothing.java | 1 - .../launcher/ContainerLauncherManager.java | 19 +-- .../launcher/ContainerLauncherWrapper.java | 2 +- .../tez/dag/app/launcher/ContainerOp.java | 2 +- .../dag/app/launcher/DagDeleteRunnable.java | 7 +- .../dag/app/launcher/DeletionTrackerImpl.java | 10 +- .../app/launcher/LocalContainerLauncher.java | 51 ++++---- .../TaskAttemptFailedDeleteRunnable.java | 7 +- .../launcher/TezContainerLauncherImpl.java | 33 ++--- .../app/launcher/TezLocalCacheManager.java | 21 +-- .../app/launcher/VertexDeleteRunnable.java | 7 +- .../AMSchedulerEventDeallocateContainer.java | 1 - .../dag/app/rm/AMSchedulerEventTAEnded.java | 2 +- .../dag/app/rm/DagAwareYarnTaskScheduler.java | 67 +++++----- .../dag/app/rm/LocalTaskSchedulerService.java | 29 +++-- .../dag/app/rm/TaskSchedulerContextImpl.java | 3 +- .../rm/TaskSchedulerContextImplWrapper.java | 8 +- .../tez/dag/app/rm/TaskSchedulerManager.java | 40 +++--- .../tez/dag/app/rm/TezAMRMClientAsync.java | 5 +- .../dag/app/rm/YarnTaskSchedulerService.java | 25 ++-- .../container/AMContainerEventCompleted.java | 2 +- .../app/rm/container/AMContainerHelpers.java | 5 +- .../dag/app/rm/container/AMContainerImpl.java | 31 ++--- .../dag/app/rm/container/AMContainerMap.java | 12 +- .../rm/container/ContainerContextMatcher.java | 5 +- .../tez/dag/app/rm/node/AMNodeImpl.java | 7 +- .../tez/dag/app/rm/node/AMNodeTracker.java | 7 +- .../dag/app/rm/node/PerSourceNodeTracker.java | 4 +- .../tez/dag/app/web/AMWebController.java | 37 +++--- .../apache/tez/dag/app/web/WebUIService.java | 23 ++-- .../apache/tez/dag/history/HistoryEvent.java | 4 +- .../tez/dag/history/HistoryEventHandler.java | 5 +- .../tez/dag/history/RecoveryConverters.java | 3 - .../dag/history/events/AMLaunchedEvent.java | 7 +- .../dag/history/events/AMStartedEvent.java | 7 +- .../dag/history/events/AppLaunchedEvent.java | 5 +- .../events/ContainerLaunchedEvent.java | 7 +- .../history/events/ContainerStoppedEvent.java | 7 +- .../history/events/DAGCommitStartedEvent.java | 7 +- .../dag/history/events/DAGFinishedEvent.java | 6 +- .../history/events/DAGInitializedEvent.java | 7 +- .../history/events/DAGKillRequestEvent.java | 7 +- .../dag/history/events/DAGRecoveredEvent.java | 5 +- .../dag/history/events/DAGStartedEvent.java | 7 +- .../dag/history/events/DAGSubmittedEvent.java | 14 +- .../events/TaskAttemptFinishedEvent.java | 27 ++-- .../events/TaskAttemptStartedEvent.java | 7 +- .../dag/history/events/TaskFinishedEvent.java | 14 +- .../dag/history/events/TaskStartedEvent.java | 7 +- .../events/VertexCommitStartedEvent.java | 6 +- .../events/VertexConfigurationDoneEvent.java | 6 +- .../history/events/VertexFinishedEvent.java | 16 ++- .../VertexGroupCommitFinishedEvent.java | 6 +- .../events/VertexGroupCommitStartedEvent.java | 6 +- .../events/VertexInitializedEvent.java | 6 +- .../history/events/VertexStartedEvent.java | 7 +- .../impl/HistoryEventJsonConversion.java | 3 +- .../impl/SimpleHistoryLoggingService.java | 7 +- .../dag/history/recovery/RecoveryService.java | 7 +- .../tez/dag/history/utils/DAGUtils.java | 7 +- .../tez/dag/history/utils/TezEventUtils.java | 1 + .../utils/TaskSpecificLaunchCmdOption.java | 5 +- .../serviceplugins/api/TaskCommunicator.java | 3 +- .../api/TaskCommunicatorContext.java | 3 +- .../org/apache/tez/state/StateMachineTez.java | 1 - .../dag/api/client/TestDAGClientHandler.java | 1 + .../dag/api/client/TestDAGClientServer.java | 4 +- .../api/client/TestVertexStatusBuilder.java | 2 +- ...GClientAMProtocolBlockingPBServerImpl.java | 15 ++- .../org/apache/tez/dag/app/MockClock.java | 4 +- .../apache/tez/dag/app/MockDAGAppMaster.java | 25 ++-- .../apache/tez/dag/app/TestDAGAppMaster.java | 67 +++++----- .../tez/dag/app/TestMemoryWithEvents.java | 13 +- .../tez/dag/app/TestMockDAGAppMaster.java | 20 +-- .../apache/tez/dag/app/TestPreemption.java | 1 + .../tez/dag/app/TestRecoveryParser.java | 12 +- .../apache/tez/dag/app/TestSpeculation.java | 7 +- .../app/TestTaskCommunicatorContextImpl.java | 3 +- .../dag/app/TestTaskCommunicatorManager.java | 18 +-- .../dag/app/TestTaskCommunicatorManager1.java | 23 ++-- .../dag/app/TestTaskCommunicatorManager2.java | 23 ++-- .../dag/app/TestTaskCommunicatorWrapper.java | 4 +- .../dag/TestRootInputInitializerManager.java | 4 +- .../dag/app/dag/TestStateChangeNotifier.java | 5 +- .../app/TestTezTaskCommunicatorManager.java | 1 + .../app/dag/impl/CallableEventDispatcher.java | 1 - .../tez/dag/app/dag/impl/TestCommit.java | 9 +- .../tez/dag/app/dag/impl/TestDAGImpl.java | 53 ++++---- .../tez/dag/app/dag/impl/TestDAGRecovery.java | 25 ++-- .../dag/app/dag/impl/TestDAGScheduler.java | 11 +- ...estDAGSchedulerNaturalOrderControlled.java | 1 + .../apache/tez/dag/app/dag/impl/TestEdge.java | 8 +- .../impl/TestImmediateStartVertexManager.java | 21 +-- .../dag/impl/TestRootInputVertexManager.java | 4 +- .../tez/dag/app/dag/impl/TestTaskAttempt.java | 31 ++--- .../tez/dag/app/dag/impl/TestTaskImpl.java | 54 ++++---- .../tez/dag/app/dag/impl/TestVertexImpl.java | 122 +++++++++--------- .../tez/dag/app/dag/impl/TestVertexImpl2.java | 8 +- .../dag/app/dag/impl/TestVertexManager.java | 13 +- .../tez/dag/app/dag/impl/TestVertexStats.java | 1 + .../TestContainerLauncherManager.java | 1 + .../TestContainerLauncherWrapper.java | 4 +- .../dag/app/launcher/TestDeletionTracker.java | 1 + .../launcher/TestTezLocalCacheManager.java | 17 +-- .../tez/dag/app/rm/TestContainerReuse.java | 31 ++--- .../app/rm/TestDagAwareYarnTaskScheduler.java | 68 +++++----- .../dag/app/rm/TestLocalTaskScheduler.java | 9 +- .../app/rm/TestLocalTaskSchedulerService.java | 7 +- .../tez/dag/app/rm/TestTaskScheduler.java | 7 +- .../dag/app/rm/TestTaskSchedulerHelpers.java | 12 +- .../dag/app/rm/TestTaskSchedulerManager.java | 16 ++- .../dag/app/rm/TestTaskSchedulerWrapper.java | 4 +- .../tez/dag/app/rm/TestTezAMRMClient.java | 11 +- .../dag/app/rm/container/TestAMContainer.java | 19 +-- .../app/rm/container/TestAMContainerMap.java | 21 +-- .../dag/app/rm/node/TestAMNodeTracker.java | 11 +- .../tez/dag/app/web/TestAMWebController.java | 14 +- .../tez/dag/helpers/DagInfoImplForTest.java | 4 +- .../dag/history/TestHistoryEventHandler.java | 1 + .../TestHistoryEventsProtoConversion.java | 32 ++--- .../impl/TestHistoryEventJsonConversion.java | 7 +- .../history/recovery/TestRecoveryService.java | 1 + .../tez/dag/history/utils/TestDAGUtils.java | 7 +- .../TestTaskSpecificLaunchCmdOption.java | 1 + .../ControlledScheduledExecutorService.java | 6 +- .../GraceShuffleVertexManagerForTest.java | 13 +- .../apache/tez/examples/CartesianProduct.java | 20 +-- .../apache/tez/examples/ExampleDriver.java | 1 - .../apache/tez/examples/HashJoinExample.java | 6 +- .../org/apache/tez/examples/JoinDataGen.java | 12 +- .../org/apache/tez/examples/JoinValidate.java | 11 +- .../apache/tez/examples/OrderedWordCount.java | 7 +- .../tez/examples/SimpleSessionExample.java | 5 +- .../tez/examples/SortMergeJoinExample.java | 6 +- .../apache/tez/examples/TezExampleBase.java | 24 ++-- .../org/apache/tez/examples/WordCount.java | 6 +- .../dag/app/TezTestServiceCommunicator.java | 15 ++- .../TezTestServiceContainerLauncher.java | 12 +- ...estServiceContainerLauncherWithErrors.java | 1 - .../TezTestServiceNoOpContainerLauncher.java | 1 + .../TezTestServiceTaskSchedulerService.java | 8 +- ...ServiceTaskSchedulerServiceWithErrors.java | 4 +- .../TezTestServiceTaskCommunicatorImpl.java | 15 ++- ...TestServiceTaskCommunicatorWithErrors.java | 10 +- .../apache/tez/service/ContainerRunner.java | 2 - .../service/MiniTezTestServiceCluster.java | 3 +- .../tez/service/impl/ContainerRunnerImpl.java | 33 ++--- .../tez/service/impl/TezTestService.java | 5 +- .../TezTestServiceProtocolClientImpl.java | 5 +- .../TezTestServiceProtocolServerImpl.java | 10 +- .../apache/tez/shufflehandler/IndexCache.java | 1 + .../tez/shufflehandler/ShuffleHandler.java | 10 +- .../tests/ExternalTezServiceTestHelper.java | 1 + .../tests/TestExtServicesWithLocalMode.java | 1 + .../tez/tests/TestExternalTezServices.java | 1 + .../tests/TestExternalTezServicesErrors.java | 6 +- .../split/TezGroupedSplitsInputFormat.java | 11 +- .../mapred/split/TezMapredSplitsGrouper.java | 14 +- .../split/SplitMetaInfoReaderTez.java | 5 +- .../split/TezGroupedSplitsInputFormat.java | 7 +- .../split/TezMapReduceSplitsGrouper.java | 14 +- .../org/apache/tez/client/MRTezClient.java | 3 +- .../tez/dag/api/client/MRDAGClient.java | 4 +- .../client/ClientServiceDelegate.java | 8 +- .../mapreduce/client/ResourceMgrDelegate.java | 5 +- .../tez/mapreduce/client/YARNRunner.java | 10 +- .../tez/mapreduce/combine/MRCombiner.java | 9 +- .../committer/MROutputCommitter.java | 9 +- .../common/MRInputAMSplitGenerator.java | 13 +- .../common/MRInputSplitDistributor.java | 5 +- .../apache/tez/mapreduce/common/Utils.java | 2 +- .../grouper/GroupedSplitContainer.java | 3 +- .../mapreduce/grouper/TezSplitGrouper.java | 6 +- .../mapreduce/hadoop/InputSplitInfoMem.java | 3 +- .../tez/mapreduce/hadoop/MRHelpers.java | 5 +- .../tez/mapreduce/hadoop/MRInputHelpers.java | 24 ++-- .../tez/mapreduce/hadoop/MRJobConfig.java | 2 +- .../hadoop/mapreduce/JobContextImpl.java | 1 - .../hadoop/mapreduce/MapContextImpl.java | 1 - .../apache/tez/mapreduce/input/MRInput.java | 14 +- .../tez/mapreduce/input/MRInputLegacy.java | 7 +- .../tez/mapreduce/input/MultiMRInput.java | 19 +-- .../tez/mapreduce/input/base/MRInputBase.java | 9 +- .../tez/mapreduce/lib/MRInputUtils.java | 5 +- .../tez/mapreduce/lib/MRReaderMapReduce.java | 15 ++- .../tez/mapreduce/lib/MRReaderMapred.java | 7 +- .../apache/tez/mapreduce/output/MROutput.java | 22 ++-- .../tez/mapreduce/output/MultiMROutput.java | 11 +- .../mapreduce/partition/MRPartitioner.java | 5 +- .../tez/mapreduce/processor/MRTask.java | 7 +- .../processor/SimpleMRProcessor.java | 5 +- .../mapreduce/processor/map/MapProcessor.java | 9 +- .../processor/reduce/ReduceProcessor.java | 7 +- .../mapred/split/TestGroupedSplits.java | 21 +-- .../apache/tez/mapreduce/TestUmbilical.java | 10 +- .../apache/tez/mapreduce/TezTestUtils.java | 4 +- .../tez/mapreduce/combine/TestMRCombiner.java | 13 +- .../common/TestMRInputAMSplitGenerator.java | 24 ++-- .../common/TestMRInputSplitDistributor.java | 8 +- .../hadoop/TestConfigTranslationMRToTez.java | 1 + .../mapreduce/hadoop/TestDeprecatedKeys.java | 3 +- .../tez/mapreduce/hadoop/TestMRHelpers.java | 1 + .../mapreduce/hadoop/TestMRInputHelpers.java | 5 +- .../tez/mapreduce/input/TestMRInput.java | 1 + .../tez/mapreduce/input/TestMultiMRInput.java | 7 +- .../mapreduce/lib/TestKVReadersWithMR.java | 21 +-- .../tez/mapreduce/output/TestMROutput.java | 9 +- .../output/TestMROutputConfigBuilder.java | 5 +- .../mapreduce/output/TestMROutputLegacy.java | 5 +- .../mapreduce/output/TestMultiMROutput.java | 7 +- .../tez/mapreduce/processor/MapUtils.java | 11 +- .../processor/map/TestMapProcessor.java | 9 +- .../processor/reduce/TestReduceProcessor.java | 19 +-- .../tez/auxservices/FadvisedChunkedFile.java | 10 +- .../tez/auxservices/FadvisedFileRegion.java | 10 +- .../apache/tez/auxservices/IndexCache.java | 1 + .../tez/auxservices/ShuffleHandler.java | 62 ++++----- .../tez/auxservices/TestIndexCache.java | 10 +- .../tez/auxservices/TestShuffleHandler.java | 31 ++--- .../auxservices/TestShuffleHandlerJobs.java | 20 +-- .../org/apache/tez/history/ATSImportTool.java | 63 ++++----- .../apache/tez/history/parser/ATSData.java | 5 +- .../tez/history/parser/ATSFileParser.java | 34 ++--- .../history/parser/ProtoHistoryParser.java | 5 +- .../history/parser/SimpleHistoryParser.java | 7 +- .../history/parser/datamodel/BaseInfo.java | 20 +-- .../history/parser/datamodel/BaseParser.java | 13 +- .../history/parser/datamodel/Constants.java | 4 +- .../history/parser/datamodel/Container.java | 4 +- .../tez/history/parser/datamodel/DagInfo.java | 40 +++--- .../parser/datamodel/TaskAttemptInfo.java | 29 +++-- .../history/parser/datamodel/TaskInfo.java | 29 +++-- .../history/parser/datamodel/VertexInfo.java | 32 ++--- .../tez/history/parser/utils/Utils.java | 9 +- .../apache/tez/history/TestHistoryParser.java | 28 ++-- .../logging/proto/DagManifesFileScanner.java | 4 +- .../logging/proto/DatePartitionedLogger.java | 7 +- .../proto/HistoryEventProtoConverter.java | 4 +- .../HistoryEventProtoJsonConversion.java | 1 + .../proto/ProtoHistoryLoggingService.java | 1 + .../logging/proto/ProtoMessageWritable.java | 2 +- .../logging/proto/ProtoMessageWriter.java | 2 +- .../proto/TestDagManifestFileScanner.java | 1 + .../proto/TestHistoryEventProtoConverter.java | 5 +- .../proto/TestProtoHistoryLoggingService.java | 4 +- .../logging/ats/TimelineCachePluginImpl.java | 5 +- .../ats/TestTimelineCachePluginImpl.java | 5 +- .../ats/acls/ATSHistoryACLPolicyManager.java | 11 +- .../ats/acls/TestATSHistoryWithACLs.java | 23 ++-- .../acls/ATSV15HistoryACLPolicyManager.java | 11 +- .../ats/ATSV15HistoryLoggingService.java | 11 +- .../history/ats/acls/TestATSHistoryV15.java | 32 ++--- .../ats/TestATSV15HistoryLoggingService.java | 3 +- .../logging/ats/ATSHistoryLoggingService.java | 9 +- .../ats/HistoryEventTimelineConversion.java | 2 +- .../ats/TestATSHistoryLoggingService.java | 35 ++--- .../ats/TestATSHistoryWithMiniCluster.java | 16 +-- .../TestHistoryEventTimelineConversion.java | 11 +- .../tez/tests/MiniTezClusterWithTimeline.java | 5 +- .../apache/tez/common/ProtoConverters.java | 10 +- .../apache/tez/runtime/InputReadyTracker.java | 2 +- .../LogicalIOProcessorRuntimeTask.java | 23 ++-- .../org/apache/tez/runtime/RuntimeTask.java | 7 +- .../tez/runtime/TezThreadDumpHelper.java | 32 ++--- .../api/events/TaskAttemptFailedEvent.java | 2 +- .../tez/runtime/api/impl/TaskStatistics.java | 1 - .../apache/tez/runtime/api/impl/TezEvent.java | 8 +- .../runtime/api/impl/TezInputContextImpl.java | 7 +- .../api/impl/TezMergedInputContextImpl.java | 6 +- .../api/impl/TezOutputContextImpl.java | 7 +- .../api/impl/TezProcessorContextImpl.java | 5 +- .../runtime/api/impl/TezTaskContextImpl.java | 7 +- .../common/resources/MemoryDistributor.java | 13 +- .../common/resources/ScalingAllocator.java | 7 +- .../runtime/internals/api/TezTrapEvent.java | 6 +- .../runtime/metrics/TaskCounterUpdater.java | 11 +- .../tez/runtime/task/ContainerReporter.java | 2 +- .../apache/tez/runtime/task/TaskReporter.java | 7 +- .../tez/runtime/task/TaskRunner2Callable.java | 1 + .../org/apache/tez/runtime/task/TezChild.java | 13 +- .../tez/runtime/task/TezTaskRunner2.java | 11 +- .../tez/runtime/task/TezTrapEventHandler.java | 10 +- .../tez/runtime/TestInputReadyTracker.java | 7 +- .../TestLogicalIOProcessorRuntimeTask.java | 7 +- .../api/impl/TestProcessorContext.java | 4 +- .../tez/runtime/api/impl/TestTaskSpec.java | 1 + .../tez/runtime/api/impl/TestTezEvent.java | 5 +- .../objectregistry/TestObjectRegistry.java | 1 + .../resources/TestMemoryDistributor.java | 3 +- .../TestFileSystemStatisticUpdater.java | 1 + .../metrics/TestTaskCounterUpdater.java | 1 + .../task/TaskExecutionTestHelpers.java | 2 +- .../runtime/task/TestContainerExecution.java | 8 +- .../tez/runtime/task/TestTaskExecution2.java | 20 +-- .../tez/runtime/task/TestTaskReporter.java | 5 +- .../tez/runtime/task/TestTezTaskRunner2.java | 1 + .../edgemanager/SilentEdgeManager.java | 6 +- .../DestinationTaskInputsProperty.java | 1 - .../vertexmanager/FairEdgeConfiguration.java | 10 +- .../vertexmanager/FairShuffleEdgeManager.java | 9 +- .../FairShuffleVertexManager.java | 37 +++--- .../InputReadyVertexManager.java | 9 +- .../vertexmanager/ShuffleVertexManager.java | 37 +++--- .../ShuffleVertexManagerBase.java | 60 ++++----- .../VertexManagerWithConcurrentInput.java | 25 ++-- .../org/apache/tez/http/HttpConnection.java | 25 ++-- .../java/org/apache/tez/http/SSLFactory.java | 35 ++--- .../http/async/netty/AsyncHttpConnection.java | 38 +++--- .../netty/TezBodyDeferringAsyncHandler.java | 21 +-- .../CartesianProductCombination.java | 7 +- .../CartesianProductConfig.java | 19 +-- .../CartesianProductEdgeManager.java | 11 +- ...artesianProductEdgeManagerPartitioned.java | 20 +-- .../CartesianProductEdgeManagerReal.java | 2 +- .../CartesianProductFilter.java | 4 +- .../CartesianProductVertexManager.java | 25 ++-- ...tesianProductVertexManagerPartitioned.java | 22 ++-- .../CartesianProductVertexManagerReal.java | 6 +- .../FairCartesianProductEdgeManager.java | 11 +- .../FairCartesianProductVertexManager.java | 36 +++--- .../CompositeInputAttemptIdentifier.java | 3 +- .../common/MemoryUpdateCallbackHandler.java | 3 +- .../library/common/TezRuntimeUtils.java | 11 +- .../library/common/ValuesIterator.java | 4 +- .../library/common/combine/Combiner.java | 2 +- .../common/readers/UnorderedKVReader.java | 15 ++- .../common/security/SecureShuffleUtils.java | 3 +- .../TezBytesWritableSerialization.java | 12 +- .../common/shuffle/DiskFetchedInput.java | 6 +- .../library/common/shuffle/Fetcher.java | 26 ++-- .../shuffle/FetcherErrorTestingConfig.java | 1 + .../shuffle/FetcherWithInjectableErrors.java | 1 + .../library/common/shuffle/InputHost.java | 1 - .../common/shuffle/LocalDiskFetchedInput.java | 10 +- .../common/shuffle/MemoryFetchedInput.java | 3 +- .../library/common/shuffle/ShuffleUtils.java | 32 ++--- .../impl/ShuffleInputEventHandlerImpl.java | 21 ++- .../common/shuffle/impl/ShuffleManager.java | 22 ++-- .../impl/SimpleFetchedInputAllocator.java | 10 +- .../orderedgrouped/FetcherOrderedGrouped.java | 20 +-- ...herOrderedGroupedWithInjectableErrors.java | 1 + .../orderedgrouped/InMemoryWriter.java | 7 +- .../shuffle/orderedgrouped/MapOutput.java | 6 +- .../shuffle/orderedgrouped/MergeManager.java | 30 +++-- .../shuffle/orderedgrouped/Shuffle.java | 17 +-- ...huffleInputEventHandlerOrderedGrouped.java | 14 +- .../orderedgrouped/ShuffleScheduler.java | 49 +++---- .../common/sort/impl/ExternalSorter.java | 18 +-- .../library/common/sort/impl/IFile.java | 17 +-- .../common/sort/impl/IFileInputStream.java | 5 +- .../common/sort/impl/PipelinedSorter.java | 29 ++--- .../library/common/sort/impl/TezMerger.java | 9 +- .../common/sort/impl/dflt/DefaultSorter.java | 23 ++-- .../task/local/output/TezTaskOutputFiles.java | 7 +- .../BaseUnorderedPartitionedKVWriter.java | 7 +- .../writers/UnorderedPartitionedKVWriter.java | 21 +-- .../HadoopKeyValuesBasedBaseEdgeConfig.java | 4 +- .../conf/OrderedGroupedKVInputConfig.java | 10 +- .../conf/OrderedPartitionedKVEdgeConfig.java | 4 +- .../OrderedPartitionedKVOutputConfig.java | 9 +- .../library/conf/UnorderedKVEdgeConfig.java | 4 +- .../library/conf/UnorderedKVInputConfig.java | 8 +- .../library/conf/UnorderedKVOutputConfig.java | 8 +- .../UnorderedPartitionedKVEdgeConfig.java | 4 +- .../UnorderedPartitionedKVOutputConfig.java | 8 +- .../ConcatenatedMergedKeyValueInput.java | 2 +- .../ConcatenatedMergedKeyValuesInput.java | 2 +- .../library/input/OrderedGroupedKVInput.java | 17 +-- .../input/OrderedGroupedMergedKVInput.java | 9 +- .../library/input/UnorderedKVInput.java | 17 +-- .../output/OrderedPartitionedKVOutput.java | 18 +-- .../library/output/UnorderedKVOutput.java | 9 +- .../output/UnorderedPartitionedKVOutput.java | 15 ++- .../library/processor/SimpleProcessor.java | 1 + .../library/processor/SleepProcessor.java | 10 +- .../WeightedScalingMemoryDistributor.java | 9 +- .../tez/runtime/library/utils/CodecUtils.java | 5 +- .../library/utils/FastByteComparisons.java | 4 +- .../TestFairShuffleVertexManager.java | 31 ++--- .../TestInputReadyVertexManager.java | 7 +- .../TestShuffleVertexManager.java | 35 ++--- .../TestShuffleVertexManagerBase.java | 42 +++--- .../TestShuffleVertexManagerUtils.java | 32 ++--- .../TestVertexManagerWithConcurrentInput.java | 19 +-- .../apache/tez/http/TestHttpConnection.java | 26 ++-- .../TestWeightedScalingMemoryDistributor.java | 5 +- .../TestCartesianProductCombination.java | 11 +- .../TestCartesianProductConfig.java | 22 ++-- .../TestCartesianProductEdgeManager.java | 18 +-- ...artesianProductEdgeManagerPartitioned.java | 24 ++-- .../TestCartesianProductVertexManager.java | 25 ++-- ...tesianProductVertexManagerPartitioned.java | 35 ++--- .../TestFairCartesianProductEdgeManager.java | 13 +- ...TestFairCartesianProductVertexManager.java | 48 +++---- .../library/cartesianproduct/TestGrouper.java | 7 +- .../library/common/TestConfigUtils.java | 11 +- .../library/common/TestValuesIterator.java | 50 +++---- .../comparator/TestProxyComparator.java | 5 +- .../common/readers/TestUnorderedKVReader.java | 21 +-- .../library/common/shuffle/TestFetcher.java | 11 +- .../common/shuffle/TestShuffleUtils.java | 47 +++---- .../TestShuffleInputEventHandlerImpl.java | 6 +- .../shuffle/impl/TestShuffleManager.java | 6 +- .../impl/TestSimpleFetchedInputAllocator.java | 5 +- .../orderedgrouped/DummyCompressionCodec.java | 12 +- .../shuffle/orderedgrouped/TestFetcher.java | 23 ++-- .../orderedgrouped/TestMergeManager.java | 11 +- .../shuffle/orderedgrouped/TestShuffle.java | 3 +- ...huffleInputEventHandlerOrderedGrouped.java | 44 ++++--- .../orderedgrouped/TestShuffleScheduler.java | 3 +- .../library/common/sort/impl/TestIFile.java | 5 +- .../common/sort/impl/TestPipelinedSorter.java | 38 +++--- .../common/sort/impl/TestTezMerger.java | 36 +++--- .../sort/impl/dflt/TestDefaultSorter.java | 18 +-- .../TestUnorderedPartitionedKVWriter.java | 39 +++--- ...TestOrderedGroupedMergedKVInputConfig.java | 4 +- .../TestOrderedPartitionedKVEdgeConfig.java | 5 +- .../TestOrderedPartitionedKVOutputConfig.java | 3 +- .../conf/TestUnorderedKVEdgeConfig.java | 1 + .../conf/TestUnorderedKVInputConfig.java | 1 + .../conf/TestUnorderedKVOutputConfig.java | 1 + .../TestUnorderedPartitionedKVEdgeConfig.java | 1 + ...estUnorderedPartitionedKVOutputConfig.java | 4 +- .../input/TestOrderedGroupedKVInput.java | 1 + .../input/TestSortedGroupedMergedInput.java | 1 + .../library/output/OutputTestHelpers.java | 1 + .../output/TestOnFileSortedOutput.java | 47 +++---- .../output/TestOnFileUnorderedKVOutput.java | 20 +-- .../TestOrderedPartitionedKVOutput2.java | 4 +- .../output/TestUnorderedKVOutput2.java | 4 +- .../TestUnorderedPartitionedKVOutput2.java | 4 +- .../testutils/RandomTextGenerator.java | 4 +- .../runtime/library/utils/TestCodecUtils.java | 5 +- .../examples/BroadcastAndOneToOneExample.java | 5 +- .../mapreduce/examples/BroadcastLoadGen.java | 6 +- .../mapreduce/examples/CartesianProduct.java | 19 ++- .../tez/mapreduce/examples/ExampleDriver.java | 1 - .../mapreduce/examples/FilterLinesByWord.java | 7 +- .../examples/FilterLinesByWordOneToOne.java | 3 +- .../tez/mapreduce/examples/MRRSleepJob.java | 13 +- .../mapreduce/examples/MapredWordCount.java | 5 +- .../examples/MultipleCommitsExample.java | 1 + .../tez/mapreduce/examples/RPCLoadGen.java | 5 +- .../tez/mapreduce/examples/SecondarySort.java | 4 +- .../apache/tez/mapreduce/examples/Sort.java | 2 +- .../examples/TestOrderedWordCount.java | 7 +- .../tez/mapreduce/examples/UnionExample.java | 8 +- .../helpers/SplitsInClientOptionParser.java | 1 - .../processor/FilterByWordInputProcessor.java | 9 +- .../FilterByWordOutputProcessor.java | 6 +- .../org/apache/tez/mapreduce/TestMRRJobs.java | 7 +- .../tez/mapreduce/TestMRRJobsDAGApi.java | 17 +-- .../tez/test/FaultToleranceTestRunner.java | 4 +- .../org/apache/tez/test/MiniTezCluster.java | 7 +- .../RecoveryServiceWithEventHandlingHook.java | 13 +- .../org/apache/tez/test/SimpleTestDAG.java | 4 +- .../tez/test/SimpleTestDAG3Vertices.java | 4 +- .../test/java/org/apache/tez/test/TestAM.java | 2 + .../org/apache/tez/test/TestAMRecovery.java | 11 +- .../TestAMRecoveryAggregationBroadcast.java | 2 + .../org/apache/tez/test/TestDAGRecovery.java | 18 ++- .../org/apache/tez/test/TestDAGRecovery2.java | 13 +- .../tez/test/TestExceptionPropagation.java | 17 ++- .../apache/tez/test/TestFaultTolerance.java | 32 ++--- .../java/org/apache/tez/test/TestInput.java | 9 +- .../org/apache/tez/test/TestLocalMode.java | 5 +- .../apache/tez/test/TestMiniTezCluster.java | 1 + .../java/org/apache/tez/test/TestOutput.java | 9 +- .../apache/tez/test/TestPipelinedShuffle.java | 18 +-- .../org/apache/tez/test/TestProcessor.java | 7 +- .../org/apache/tez/test/TestRecovery.java | 8 +- .../apache/tez/test/TestSecureShuffle.java | 1 + .../test/TestTaskErrorsUsingLocalMode.java | 3 +- .../java/org/apache/tez/test/TestTezJobs.java | 61 ++++----- .../tez/test/dag/FailingDagBuilder.java | 6 +- .../apache/tez/test/dag/MultiAttemptDAG.java | 26 ++-- .../tez/test/dag/SimpleReverseVTestDAG.java | 4 +- .../apache/tez/test/dag/SimpleVTestDAG.java | 4 +- .../org/apache/tez/analyzer/CSVResult.java | 15 ++- .../plugins/ContainerReuseAnalyzer.java | 6 +- .../plugins/CriticalPathAnalyzer.java | 5 +- .../analyzer/plugins/HungTaskAnalyzer.java | 8 +- .../analyzer/plugins/LocalityAnalyzer.java | 6 +- .../plugins/OneOnOneEdgeAnalyzer.java | 13 +- .../analyzer/plugins/ShuffleTimeAnalyzer.java | 8 +- .../tez/analyzer/plugins/SkewAnalyzer.java | 8 +- .../analyzer/plugins/SlowNodeAnalyzer.java | 12 +- .../analyzer/plugins/SlowTaskIdentifier.java | 8 +- .../plugins/SlowestVertexAnalyzer.java | 10 +- .../analyzer/plugins/SpillAnalyzerImpl.java | 6 +- .../plugins/TaskAssignmentAnalyzer.java | 6 +- .../plugins/TaskConcurrencyAnalyzer.java | 8 +- .../tez/analyzer/plugins/TezAnalyzerBase.java | 2 +- .../VertexLevelCriticalPathAnalyzer.java | 22 ++-- .../apache/tez/analyzer/utils/SVGUtils.java | 15 ++- .../org/apache/tez/analyzer/utils/Utils.java | 11 +- .../org/apache/tez/analyzer/TestAnalyzer.java | 7 +- 638 files changed, 3800 insertions(+), 3369 deletions(-) diff --git a/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28.java b/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28.java index c7d8c63ecc..264a3b4fe5 100644 --- a/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28.java +++ b/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28.java @@ -19,6 +19,7 @@ package org.apache.tez.hadoop.shim; import org.apache.hadoop.yarn.api.records.FinalApplicationStatus; + import org.junit.Assert; import org.junit.Test; diff --git a/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28Provider.java b/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28Provider.java index 353d590e6d..c5563fc6dc 100644 --- a/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28Provider.java +++ b/hadoop-shim-impls/hadoop-shim-2.8/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShim28Provider.java @@ -19,6 +19,7 @@ package org.apache.tez.hadoop.shim; import org.apache.hadoop.conf.Configuration; + import org.junit.Assert; import org.junit.Test; diff --git a/hadoop-shim/src/main/java/org/apache/tez/hadoop/shim/HadoopShimsLoader.java b/hadoop-shim/src/main/java/org/apache/tez/hadoop/shim/HadoopShimsLoader.java index 9d9dc3ff55..ce5b6b3627 100644 --- a/hadoop-shim/src/main/java/org/apache/tez/hadoop/shim/HadoopShimsLoader.java +++ b/hadoop-shim/src/main/java/org/apache/tez/hadoop/shim/HadoopShimsLoader.java @@ -24,11 +24,12 @@ import org.apache.hadoop.classification.InterfaceAudience.Private; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.util.VersionInfo; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import com.google.common.annotations.VisibleForTesting; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + @Private public class HadoopShimsLoader { diff --git a/hadoop-shim/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShimsLoader.java b/hadoop-shim/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShimsLoader.java index b0215ed7a3..8de56454b2 100644 --- a/hadoop-shim/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShimsLoader.java +++ b/hadoop-shim/src/test/java/org/apache/tez/hadoop/shim/TestHadoopShimsLoader.java @@ -20,6 +20,7 @@ import org.apache.hadoop.conf.Configuration; import org.apache.tez.hadoop.shim.DummyShimProvider.DummyShim; + import org.junit.Assert; import org.junit.Test; diff --git a/pom.xml b/pom.xml index b1c93a75c1..7c429ddde3 100644 --- a/pom.xml +++ b/pom.xml @@ -994,6 +994,20 @@ false + + com.diffplug.spotless + spotless-maven-plugin + 2.43.0 + + true + + + java,javax,org.apache,com,net,io + + + + + org.codehaus.mojo build-helper-maven-plugin @@ -1146,6 +1160,19 @@ false + + com.diffplug.spotless + spotless-maven-plugin + + + spotless-check + validate + + check + + + +