From 7164323193cccf517c54fc34a7834ef4c036e7ed Mon Sep 17 00:00:00 2001 From: Taylor Frey Date: Fri, 15 Jul 2022 11:04:26 -0600 Subject: [PATCH] Prevent RequestedName field from being returned in Topologies and Server Capability responses --- CHANGELOG.md | 1 + docs/source/api/v4/server_capabilities.rst | 2 +- .../traffic_ops_golang/servercapability/servercapability.go | 2 +- traffic_ops/traffic_ops_golang/topology/topologies.go | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9e4a1be00f..fb2ed1371c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -65,6 +65,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#6933](https://github.com/apache/trafficcontrol/issues/6933) Fixed tc-health-client to handle credentials files with special characters in variables - [#6776](https://github.com/apache/trafficcontrol/issues/6776) User properties only required sometimes - Fixed TO API `GET /deliveryservicesserver` causing error when an IMS request is made with the `cdn` and `maxRevalDurationDays` parameters set. +- [#6792](https://github.com/apache/trafficcontrol/issues/6792) Remove extraneous field from Topologies and Server Capability POST/PUT. ### Removed - Remove `client.steering.forced.diversity` feature flag(profile parameter) from Traffic Router (TR). Client steering responses now have cache diversity by default. diff --git a/docs/source/api/v4/server_capabilities.rst b/docs/source/api/v4/server_capabilities.rst index 4b552612c3..048d4899a1 100644 --- a/docs/source/api/v4/server_capabilities.rst +++ b/docs/source/api/v4/server_capabilities.rst @@ -153,7 +153,7 @@ Request Structure .. code-block:: http :caption: Request Example - PUT /api/4.0/server_capabilities/edit?name=RAM HTTP/1.1 + PUT /api/4.0/server_capabilities?name=RAM HTTP/1.1 Host: trafficops.infra.ciab.test User-Agent: curl/7.47.0 Accept: */* diff --git a/traffic_ops/traffic_ops_golang/servercapability/servercapability.go b/traffic_ops/traffic_ops_golang/servercapability/servercapability.go index daffb54387..cd4f122d5e 100644 --- a/traffic_ops/traffic_ops_golang/servercapability/servercapability.go +++ b/traffic_ops/traffic_ops_golang/servercapability/servercapability.go @@ -36,7 +36,7 @@ import ( type TOServerCapability struct { api.APIInfoImpl `json:"-"` - RequestedName string + RequestedName string `json:"-"` tc.ServerCapability } diff --git a/traffic_ops/traffic_ops_golang/topology/topologies.go b/traffic_ops/traffic_ops_golang/topology/topologies.go index df9ead8bbd..988913cc9d 100644 --- a/traffic_ops/traffic_ops_golang/topology/topologies.go +++ b/traffic_ops/traffic_ops_golang/topology/topologies.go @@ -46,7 +46,7 @@ import ( type TOTopology struct { api.APIInfoImpl `json:"-"` Alerts tc.Alerts `json:"-"` - RequestedName string + RequestedName string `json:"-"` tc.Topology }