From a4e3483ee0daab89e26d700af18478e9a417bbbc Mon Sep 17 00:00:00 2001
From: Damian Meden <dmeden@apache.org>
Date: Mon, 18 Sep 2023 17:01:10 +0200
Subject: [PATCH] CID-1512733: Fix coverity issue

---
 src/traffic_ctl/CtrlPrinters.cc | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/traffic_ctl/CtrlPrinters.cc b/src/traffic_ctl/CtrlPrinters.cc
index a4afc454fa5..7d5499e6124 100644
--- a/src/traffic_ctl/CtrlPrinters.cc
+++ b/src/traffic_ctl/CtrlPrinters.cc
@@ -180,7 +180,8 @@ ConfigShowFileRegistryPrinter::write_output(YAML::Node const &result)
 void
 ConfigSetPrinter::write_output(YAML::Node const &result)
 {
-  static const std::unordered_map<std::string, std::string> Update_Type_To_String_Message = {
+  using TypeToStringMap                                      = std::unordered_map<std::string, std::string>;
+  static const TypeToStringMap Update_Type_To_String_Message = {
     {"0", "Set {}"                                                                                          }, // UNDEFINED
     {"1", "Set {}, please wait 10 seconds for traffic server to sync configuration, restart is not required"}, // DYNAMIC
     {"2", "Set {}, restart required"                                                                        }, // RESTART_TS
@@ -190,8 +191,8 @@ ConfigSetPrinter::write_output(YAML::Node const &result)
   try {
     auto const &response = result.as<ConfigSetRecordResponse>();
     for (auto &&updatedRec : response.data) {
-      if (auto search = Update_Type_To_String_Message.find(updatedRec.updateType);
-          search != std::end(Update_Type_To_String_Message)) {
+      TypeToStringMap::const_iterator search = Update_Type_To_String_Message.find(updatedRec.updateType);
+      if (search != std::end(Update_Type_To_String_Message)) {
         std::cout << swoc::bwprint(text, search->second, updatedRec.recName) << '\n';
       } else {
         std::cout << "Oops we don't know how to handle the update status for '" << updatedRec.recName << "' ["